Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-07-26] IOU - Money request header is not greyed out in offline mode #22640

Closed
5 of 6 tasks
lanitochka17 opened this issue Jul 11, 2023 · 15 comments
Closed
5 of 6 tasks
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering

Comments

@lanitochka17
Copy link

lanitochka17 commented Jul 11, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #21918

Action Performed:

  1. Go to staging.new.expensify.com
  2. Disconnect network
  3. Click + > Request money > Enter amount > Select contact > Submit
  4. Click on the payment request in the new DM

Expected Result:

Money request header is greyed out

Actual Result:

Money request header is not greyed out

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.39.5

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6123789_20230711_211526.mp4
Bug6123789_Screenshot_2023-07-11_at_21 15 56

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Jul 11, 2023
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Jul 11, 2023

Triggered auto assignment to @danieldoglas (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@ShogunFire
Copy link
Contributor

I will create a PR

@danieldoglas
Copy link
Contributor

Assigning @aimane-chnaif @madmax330 since this is a regression related to an issue you're managing.

@danieldoglas
Copy link
Contributor

Also I don't think this is a deploy blocker

@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Jul 11, 2023
@madmax330
Copy link
Contributor

Agreed, removing the label

@madmax330 madmax330 added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Jul 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 18, 2023

@madmax330, @aimane-chnaif Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Jul 19, 2023
@melvin-bot melvin-bot bot changed the title IOU - Money request header is not greyed out in offline mode [HOLD for payment 2023-07-26] IOU - Money request header is not greyed out in offline mode Jul 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 19, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jul 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 19, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.42-26 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-07-26. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jul 25, 2023
@melvin-bot melvin-bot bot added the Overdue label Jul 27, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 28, 2023

@madmax330, @aimane-chnaif Whoops! This issue is 2 days overdue. Let's get this updated quick!

@madmax330
Copy link
Contributor

Not overdue

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jul 31, 2023
@madmax330
Copy link
Contributor

Not overdue

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Aug 2, 2023
@madmax330
Copy link
Contributor

Not overdue

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Aug 7, 2023
@madmax330
Copy link
Contributor

@aimane-chnaif we can close this out right? Since it's not a new issue, but one that stems from the PR for the other issue there's not payment to make right?

@melvin-bot melvin-bot bot removed the Overdue label Aug 10, 2023
@aimane-chnaif
Copy link
Contributor

right, no payment needed here. Let's close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

6 participants