Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2023-07-26 #23657

Closed
43 tasks done
OSBotify opened this issue Jul 26, 2023 · 15 comments
Closed
43 tasks done

Deploy Checklist: New Expensify 2023-07-26 #23657

OSBotify opened this issue Jul 26, 2023 · 15 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Jul 26, 2023

Release Version: 1.3.46-0
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Jul 26, 2023
@OSBotify
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.46-0 🚀

@marcaaron
Copy link
Contributor

We checked off #23680 as per this comment

@marcaaron
Copy link
Contributor

Checking off #23684 as per #23684 (comment)

@mvtglobally
Copy link

@marcaaron Regression is at 50%

Current updates
#23342 is failing #23684
#23360 is failing #23031 (comment)

@mvtglobally
Copy link

@marcaaron We are down to last 3%

Current updates
#20821 is failing #23680
#21950 pending Android validation
#22906 issue observed #23630. pls double check if related
#23342 is failing #23684
#23360 is failing #23031 (comment)

@mvtglobally
Copy link

Regression is completed

@marcaaron
Copy link
Contributor

Checking off #23725 as per #23725 (comment)

@marcaaron
Copy link
Contributor

Chatted with Franc and we are going to remove the blocker on #23675 as it is not repro on staging.

@marcaaron
Copy link
Contributor

Checking off #23727 as per #23727 (comment)

@marcaaron
Copy link
Contributor

#21950 pending Android validation

@mvtglobally what did you mean by this one? Ok to check off now?

@mvtglobally
Copy link

@marcaaron Yes, #21950 is pass

@marcaaron
Copy link
Contributor

Besides the crash related to Reanimated the rest of the Firebase issues look very minor. Created threads in #deployer and tagged a few engineers who I think can look into them.

@marcaaron
Copy link
Contributor

Working on the last blocker with @stitesExpensify in this thread.

@marcaaron
Copy link
Contributor

all blockers resolved.

@marcaaron
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

4 participants