Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding emoji by text in edit shifts cursor #25526

Closed
1 of 6 tasks
kavimuru opened this issue Aug 19, 2023 · 7 comments
Closed
1 of 6 tasks

Adding emoji by text in edit shifts cursor #25526

kavimuru opened this issue Aug 19, 2023 · 7 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@kavimuru
Copy link

kavimuru commented Aug 19, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the app
  2. Open any report
  3. Send any message
  4. Edit the message
  5. At the end, add any emoji using text eg: :joy: (colon joy colon)
  6. Observe that cursor shifts position to few characters back

Expected Result:

Cursor should be at the end after adding emoji in edit message

Actual Result:

Cursor shifts few characters before after adding emoji in edit message

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.55.2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

cursor.shifts.few.characters.back.in.edit.mp4
Recording.1482.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692436446568749

View all open jobs on GitHub

@kavimuru kavimuru added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Aug 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 19, 2023

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Aug 19, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Aug 19, 2023

Triggered auto assignment to @stitesExpensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@Nikhil-Vats
Copy link
Contributor

Probably had the same RC as #25413 which is fixed so not reproducible on main anymore.

Screen.Recording.2023-08-19.at.6.41.42.PM.mov

@conorpendergrast
Copy link
Contributor

I can reproduce this on Safari on v1.3.55-7 (not on OSX desktop though).

Does seem pretty similar to #25413, so I think we're ok to downgrade to Daily as a result.

@stitesExpensify Can you check and confirm, and we'll close this out as a dupe of #25413?

@conorpendergrast conorpendergrast added Daily KSv2 and removed Hourly KSv2 labels Aug 21, 2023
@mountiny mountiny removed the DeployBlockerCash This issue or pull request should block deployment label Aug 21, 2023
@mountiny
Copy link
Contributor

Confirmed this is fixed in main so I am removing the label and I think we can actually close this issue without reporting bonus as the root cause was already fixed by another report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

6 participants