Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request money - Console error shows up when opening request money page #25683

Closed
1 of 6 tasks
lanitochka17 opened this issue Aug 22, 2023 · 11 comments
Closed
1 of 6 tasks
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Aug 22, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #24301

Action Performed:

  1. Go to staging.new.expensify,com
  2. Go to + > Request money

Expected Result:

There is no console error

Actual Result:

Console error shows up when opening request money page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • Windows / Chrome
  • MacOS / Desktop

Version Number: 1.3.56-2

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6173180_20230822_111113.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Aug 22, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 22, 2023

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Aug 22, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment and removed Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Aug 22, 2023
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Aug 22, 2023

Triggered auto assignment to @tgolen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@s-alves10
Copy link
Contributor

Isn't this a wrong permission issue of mapbox sdk?

@tgolen
Copy link
Contributor

tgolen commented Aug 22, 2023

@hayata-suenaga Is this something you are aware of and working on?

@hayata-suenaga
Copy link
Contributor

@tgolen I believe once this Web-E PR is deployed to production, the issue will be resolved.

@tgolen
Copy link
Contributor

tgolen commented Aug 22, 2023

OK, thank you. Is the plan to CP that to production, or let this stay a deploy blocker in NewDot until it's deployed?

@hayata-suenaga
Copy link
Contributor

UPDATE: Looking at the error message closely, the issue should be resolved once the App main that updated the react-native-x-maps version is deployed (so that changes made in this PR are reflected).

@hayata-suenaga
Copy link
Contributor

Although the error messages are logged out, I don't think this is a deploy blocker. All error messages are related to the map's styling information not being able to be fetched. It just affect the Map's styling (it uses default style vs. Expensify style). But the issue will be fixed in the next deployment anyway.

@tgolen do you think we can remove DeployBlocker label?

@tgolen
Copy link
Contributor

tgolen commented Aug 22, 2023

Yeah, as long as functionality isn't affected I think it's fine. I'll close this out since the issue is resolved already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants