Login - Unable to log in manually with locked gmail but able to log in with Google

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Precondition: Have a Gmail account that is locked.
To create a locked Gmail:

1. Go to Settings > Profile > Contact method > New contact method.
2. Add an invalid email address (eg, dusjosjkposakpa@gmail.com
3. Save and log out.
4. Log in with primary contact method.
   Steps:
5. Go to staging.new.expensify.com.
6. Log in with Google witth the locked accout.

Expected Result:

Since user is blocked from manually logging in with the locked Gmail, login with Google should be blocked as well

Actual Result:

User is able to login with Google when manually logging in with the locked Gmail fails

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome
• Windows / Chrome

Version Number: 1.3.56-7

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6173784_20230822_172155.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @grgia (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[lindboe]

@marcochavezf, this looks like maybe a server-side issue with Google Sign-In?

[marcochavezf]

Yeah, this is a backend issue from our side. I don't know exactly how we're triggering the suspended email message, but I think we'd need to hook up that logic to the SignInWithGoogle API command. So this can only be fixed internally.

Since this is introduced with the new Google sign-in functionality, I don't think this should be a blocker.

[grgia]

@marcochavezf could you take over this issue in that case?

[roryabraham]

Since this is a back-end issue, we're not going to block NewDot deploy on this. But we'll keep it as a daily

[melvin-bot]

@marcochavezf Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@marcochavezf 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

@marcochavezf 10 days overdue. I'm getting more depressed than Marvin.

[marcochavezf]

No update

[melvin-bot]

@marcochavezf Still overdue 6 days?! Let's take care of this!

[melvin-bot]

@marcochavezf 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[marcochavezf]

No update, prioritizing wave7 atm

[marcochavezf]

No update

[marcochavezf]

No update, focused on wave bugs

[marcochavezf]

No update

[marcochavezf]

Focused on wave issues, no update

[marcochavezf]

No update

[marcochavezf]

No update, focused on wave work

[marcochavezf]

No update, posted in wave9 to ask if it should part of it https://expensify.slack.com/archives/C05NJ4SLBMF/p1707159629690479

[marcochavezf]

No update, focused on critical wave issues and older tasks

[marcochavezf]

No update, focused on critical and high wave tasks

[marcochavezf]

After some investigation, I found out this error is only shown when our email providers can't send the validation code for some reason (has the nvp expensify_emailDeliveryFailure). Since the user is trying to sign in via Google, we don't send a validation code. Also, we don't show this error in OldDot when the user has the nvp expensify_emailDeliveryFailure and sign in via SSO, so I'm going to close it out.