[HOLD for payment 2023-10-09] [HOLD for payment 2023-10-05] [HOLD for payment 2023-09-27] [$1000] Stop using report.participants in favor of report.participantAccountIDs

[puneetlath]

We need to stop using report.participants and instead use report.participantAccountIDs. Now that #24320 is done, we should be able to remove all uses of report.participants in the App.

Let's go through and find everywhere that we use the participants array from the Onyx report object and instead use the participantAccountIDs array instead.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0155ce6d585250b4c1
• Upwork Job ID: 1694376588443893760
• Last Price Increase: 2023-08-23

[melvin-bot]

Current assignee @puneetlath is eligible for the NewFeature assigner, not assigning anyone new.

[lukemorawski]

Hey it's Lucas from Callstack. Happy to work on that ticket

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0155ce6d585250b4c1

[melvin-bot]

Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @burczu (External)

[daordonez11]

I would like to work on this, I have helped find some "unknown" user issues so I think I can help with migration and testing for the cases. In case Luke wants help or he is OOO I'm able to help with this issue.

[lukemorawski]

@puneetlath Hey it's Lucas from Callstack. Happy to work on that

[puneetlath]

Thanks @lukemorawski. Mind providing on ETA for when you think you'll be able to get a PR up?

[lukemorawski]

Should be today :) @puneetlath

[puneetlath]

Ok, so #26102 got us one step further, but we need to fully remove any participants usage in the app from all report types: reports, IOUs, tasks, etc.

@lukemorawski can you do the following:

1. list out every place in the app where we are currently using participants
2. for any of those places where there isn't an obvious way to use participantAccountIDs instead, start a discussion either here or in slack about how we can go about removing them

This is a very high priority for us, so let me know if this is something you're able to focus on this week or whether we need to recruit more help. Thanks!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.71-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Refactor/25714 replace participants with participantAccountIDs #27369

If no regressions arise, payment will be issued on 2023-09-27. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @burczu does not require payment (Contractor)
• @lukemorawski does not require payment (Contractor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[puneetlath]

For now I'll push my changes with removing deprecated getChatByParticipantsByLoginList method which was using report.participants.

Sounds good.

The only additional change that comes to my mind now is to refactor both methods into one (to accept userLogins and accountIDs), but please let me know if it's necessary.

Yeah, good question. I'm trying to figure out if it's actually possible to start a group chat with someone you "know" and someone you "don't know" in NewDot today. It doesn't seem like there is from what I can find. So maybe this isn't necessary.

[koko57]

ok, PR opened: #27828 🙂

[puneetlath]

@koko57 I've merged that PR. We should be good to stop sending report.participants from the back-end now, correct?

[koko57]

@puneetlath yeah, I think we're all set now. And as we decided to use participants for iou (as a temporary object in the Onyx) I think we can revert #27369

[puneetlath]

Ok great! I'll get the back-end PR prepared.

Mind going ahead and creating the revert PR? And we can ask @burczu to review that one as well. Thank you!

[koko57]

@puneetlath yeah, of course! I'll take care of it

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.74-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: remove deprecated getChatByParticipantsByLoginList method #27828

If no regressions arise, payment will be issued on 2023-10-05. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @burczu does not require payment (Contractor)
• @lukemorawski does not require payment (Contractor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[puneetlath]

There are no contributors to pay out here, so I'm going to go ahead and close this.

Thanks again for your help getting this across the finish line @koko57 @burczu and @lukemorawski!

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.75-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• chore: revert pull 27369 changes #28117

If no regressions arise, payment will be issued on 2023-10-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @burczu does not require payment (Contractor)
• @lukemorawski does not require payment (Contractor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty