Login - Focus remains on last digit after login with wrong link and requesting new code

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open iOS or Android App
2. On the login screen, enter a new account email
3. Open the validate email and copy the link
4. Modify the last part of the link to make 'wrong link'
5. Navigate to this 'wrong link'
6. Checked that "Magic code is incorrect" is displayed
7. Request a new magic link

Expected Result:

Wrong magic code cleared and focus moved to first digit

Actual Result:

Wrong magic code cleared and focus moved to last digit

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.56-8

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6173935_T3605918-Android-Invalid-Link-New-Code-Focus.mp4

Bug6173935_T3605918-iOS-Invalid-Link-New-Code-Focus.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @roryabraham (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[roryabraham]

Was able to reproduce this one

[roryabraham]

Not consistently reproducible. Appears to be the result of some race condition maybe?

[roryabraham]

Got a fix

[roryabraham]

PR is up and ready for review

[roryabraham]

QA'd this and it's fixed on staging by the revert