[hold for payment 2023-08-30] [$1000] Google icon on sign in page shows overflow horizontal scrolling bars

[marcaaron]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to sign in page
2. See bars

Expected Result:

Describe what you think should've happened

Actual Result:

Describe what actually happened

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number:
Reproducible in staging?: Yes
Reproducible in production?: No (IT IS A NEW FEATURE)
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @marcaaron
Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0150e862176e606409
• Upwork Job ID: 1694758363108376576
• Last Price Increase: 2023-08-24

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @luacmartins (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[0xmiros]

I have a quick fix:

App/src/styles/styles.js

Line 3648 in 8d5ae3a

overflowY: 'hidden',

replacing overflowY: 'hidden' -> overflow: 'hidden' fixes this bug

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[marcaaron]

@0xmiroslav has a solution here: https://expensify.slack.com/archives/C049HHMV9SM/p1692821650897609?thread_ts=1692820693.322909&cid=C049HHMV9SM

Sounds about right to me.

[joekaufmanexpensify]

@0xmiroslav mind completing the BZ checklist when you have a sec so we can prep to issue payment? TY!

[joekaufmanexpensify]

Still pending BZ checklist completion

[0xmiros]

• The PR that introduced the bug has been identified. Link to the PR: Hide Overflow of Google Signin Button [DEPLOY BLOCKER] #25789 which fixed Safari glitch issue.
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: They're already aware of this in slack thread - https://expensify.slack.com/archives/C049HHMV9SM/p1692820693322909
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug.
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

As this is super minor UI bug and follow-up of new google signin feature, no need regression test.

[joekaufmanexpensify]

BZ checklist is complete!

[joekaufmanexpensify]

Only payment we need to make here is $1,500 to @0xmiroslav. $1,000 for their PR, and then $500 speed bonus since this PR was merged in less than one day!

[0xmiros]

My payment method is still in discussion. Please hold my payment yet and update to weekly. Thanks

[joekaufmanexpensify]

Sounds good! LMK once you're ready to proceed.

[joekaufmanexpensify]

@0xmiroslav is payment here still held?

[0xmiros]

yes

[joekaufmanexpensify]

Got it, ty!

[joekaufmanexpensify]

@0xmiroslav is this still blocked?

[0xmiros]

yes still

[luacmartins]

Maybe we can combine all held payment in a single tracking issue and close this one?

[joekaufmanexpensify]

@0xmiroslav Do you expect the issue to be resolved soon? If it's going to be this week, IMO it feels simpler to just wait and pay this. But if not, agree it may make sense to look into consolidating.

[0xmiros]

I will update you asap. I am also still waiting for update from my local accountant.

[joekaufmanexpensify]

@0xmiroslav any update here?

[0xmiros]

Not yet but soon. Let's close this for now so you don't get notified. I am tracking so will ping here when ready.

[joekaufmanexpensify]

Got it, sounds good. TY!