[HOLD for payment 2023-10-09] [$500] Login - Abracadabra/2FA page displays but user can't login/continue until page is reloaded

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to staging.new.expensify.com
2. Login with new account / existing account / 2FA account
3. Copy 'Magic Link' from validation email
4. Open a new tab and navigate to the staging magic link
5. Verify the 'Abracadabra' / '2FA required' page is displayed
6. Navigate to the original tab
7. Verify the user is logged in with the new / existing account or page for 2FA input is displayed

Expected Result:

User is logged in with the new / existing account or page for 2FA input is displayed without reloading the page

Actual Result:

The user should reload the page to login or to enter 2FA

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.58-1

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

mWeb-user-not-login-but-abracadabra-displayed.mp4

Screen_Recording_20230829_161427_Chrome.mp4

Expensify/Expensify Issue URL:

Issue reported by: @Natnael-Guchima in #25979

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0186f5d4f5c7886b4e
• Upwork Job ID: 1700167803057692672
• Last Price Increase: 2023-09-22

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @arosiclair (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Natnael-Guchima]

Hey guys, I reported this issue earlier here. this behavior is also observable on the 'unlink secondary contact method flow'

[arosiclair]

I was able to reproduce this on staging web v1.3.58-1. And is not reproducible on prod so this definitely seems to be a regression.

[arosiclair]

Only related PRs I see are these, but I don't think they've broken anything

• Fix for frozen UI state on desktop after redirect from 3rd party sign in #25706
• Fix Apple Sign In token path #25710

@johnmlee101 @NikkiWines any ideas?

[luacmartins]

@arosiclair what's the latest here?

[arosiclair]

Repro'd on dev as well. It looks like the validate page and sign in commands are all working correctly. It seems like the 2FA page on the original tab is just not re-rendering after the session is updated in Onyx.

[luacmartins]

I can reproduce in dev too. It seems like this subscriber is never getting the new value, so we don't re-render the navigator to redirect the user to the auth screens. I'm not sure why though.

[luacmartins]

This seems to be a regression from #25565. Reverting that PR fixes the issue. I'm gonna demote this issue to NAB since it's small, we have an easy workaround (refresh the page), we got a good performance improvement from that PR and the fix will likely be in Onyx.

@hannojg can you take a look at this since you worked on the Onyx improvements, please!

[luacmartins]

@hannojg are we addressing the regressions from thee Onyx migration to idb-keyval anywhere?

[melvin-bot]

@arosiclair, @luacmartins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[ospfranco]

#28299 has been merged, you can test directly on main or wait for a deployment to staging.

[arosiclair]

@abdulrahuman5196 can you verify this bug is fixed on staging?

[Natnael-Guchima]

@arosiclair Yes it is fixed.

login1.mov

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.75-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Bump onyx #28299

If no regressions arise, payment will be issued on 2023-10-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @ospfranco does not require payment (Contractor)
• @abdulrahuman5196 requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
• [@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@abdulrahuman5196] Determine if we should create a regression test for this bug.
• [@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[arosiclair]

Thank you @Natnael-Guchima. I think this is good to wait for the regression period 👍

[mvtglobally]

Issue not reproducible during KI retests. (Second week)

[abdulrahuman5196]

The PR that introduced the bug has been identified. Link to the PR:

This issue was caused as a side effect of the onyx performance improvement - Expensify/react-native-onyx#280

The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

#25565 (comment)

Determine if we should create a regression test for this bug.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

No. Its a straightforward login usecase and regression test should be already present for the same.

[stephanieelliott]

Summarizing payment on this issue -- @Natnael-Guchima @abdulrahuman5196 I've extended an offer to you on Upwork, can you please accept when you get a chance?

• Issue reporter: @Natnael-Guchima $250, pay via Upwork
• Contributor: @ospfranco (no payment due)
• Contributor+: @abdulrahuman5196 $500, pay via Upwork

Upwork job is here, no bonus is included on final payout

[Natnael-Guchima]

Accepted the offer. Thanks @stephanieelliott

[mvtglobally]

Issue not reproducible during KI retests. (Third week)

[luacmartins]

Just pending payment

[abdulrahuman5196]

@stephanieelliott Gentle ping on payment processing. Pending for more than a week.

[stephanieelliott]

All paid!