[HOLD for payment 2023-09-18] [$500] Deeplinks - Not found page for concierge chat link after sign in

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to staging.new.expensify.com and sign out if needed
2. Go to staging.new.expensify.com/concierge
3. Sign in

Expected Result:

The concierge chat is displayed

Actual Result:

A not found page is displayed

Workaround:

Go home and re-open the concierge chat

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.59

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6182942_navigated_to_the_concierge_chat.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01732ad142820a35d9
• Upwork Job ID: 1697400392903643136
• Last Price Increase: 2023-09-01
• Automatic offers:
• fedirjh | Reviewer | 26535484
• Talha345 | Contributor | 26535485

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @neil-marcellini (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[neil-marcellini]

This is reproducible on prod with the following steps, so it's not a deploy blocker. I think it's also reproducible on all web platforms.

1. Go to new.expensify.com and sign out if needed
2. Go to new.expensify.com/concierge
3. Sign in

Actual result: A not found page is displayed
Expected result: The concierge chat is displayed

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[neil-marcellini]

@lanitochka17 please try to use the most simple reproduction steps possible, check if it affects all platforms, and check if it is reproducible on production before creating a deploy blocker.

[neil-marcellini]

@joekaufmanexpensify I bet this can be fixed externally

[neil-marcellini]

Un-assigning since engineering is no longer needed until a C+ approves a proposal.

[Talha345]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Visiting the concierge using deep link when logged out shows the not found page upon login.

What is the root cause of that problem?

The RC of this problem is the following if clause in the navigateToConciergeChat method which does not make any sense.

// In order not to delay the report life cycle, we first navigate to the unknown report
if (!Navigation.getTopmostReportId()) {
            Navigation.navigate(ROUTES.REPORT);
}

The if clause means that if the reportID returned by getTopmostReportId is undefined, it navigates to ROUTES.REPORT which is equals to 'r' and therefore we get the not found page.

I did some digging to find out why this if clause was actually introduced, and found that it was introduced in #19294. Also it is worth noting that the comment on top of the if clause does not make any sense and an engineer also commented the same thing here on the PR.

It seems to me that while testing the PR, the reviewer found 2 regressions which he mentioned here #19294 (comment) .The PR author then provided a solution to the regressions here #19294 (comment) by adding this if clause as a workaround to just prevent the delay being caused which resulted in a full screen loader instead of the skeleton view loaders at that time.The workaround sucks IMO because it does not make any sense logically and just causes an extra redirect to first the undefined report and then the original report.

What changes do you think we should make in order to solve the problem?

We should just remove the if clause mentioned above to fix this issue.I have tested this and it works like a charm for an existing account as well as new account and does not cause any regressions that were mentioned above as in the original PR.

Result videos after removing the if clause are attached below.

What alternative solutions did you explore? (Optional)

N/A

Result

Existing Account

existing-account.mov

New Account

new-account.mov

[joekaufmanexpensify]

Reproduced.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01732ad142820a35d9

[melvin-bot]

Current assignee @joekaufmanexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[Talha345]

@fedirjh @deetergp @joekaufmanexpensify PR is ready for review! #26919

[melvin-bot]

🎯 ⚡️ Woah @fedirjh / @Talha345, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @Talha345 got assigned: 2023-09-06 22:07:38 Z
• when the PR got merged: 2023-09-07 19:32:12 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.66-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix concierge not found error! #26919

If no regressions arise, payment will be issued on 2023-09-18. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @Talha345 requires payment offer (Contributor)
• @fedirjh requires payment offer (Reviewer)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@fedirjh] The PR that introduced the bug has been identified. Link to the PR: Fix duplicate concierge report was created  #19294
• [@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Fix duplicate concierge report was created  #19294 (comment)
• [@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A Nothing to add to the checklist, it should’ve been caught during testing.
• [@fedirjh] Determine if we should create a regression test for this bug.
• [@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: NAN, already covered by existing regression test.

[joekaufmanexpensify]

@fedirjh mind handling the BZ checklist this week so we can prep to issue payment?

[fedirjh]

BugZero Checklist:

• Link to the PR: Fix duplicate concierge report was created  #19294
• Link to comment: Fix duplicate concierge report was created  #19294 (comment)
• Link to discussion: N/A Nothing to add to the checklist, it should’ve been caught during testing.
• Determine if we should create a regression test for this bug: ✅ Update existing test

---

We can update this regression test

• [HOLD for payment 2023-06-02] [HOLD for payment 2023-06-01] [$1000] Duplicate Concierge chat created when user sign in with https://new.expensify.com/concierge link #17884 (comment)

1. Logout if you already logged in
2. Go to https://new.expensify.com/concierge directly from address bar
3. Enter new email address on login screen
4. Enter magic code which was sent to email
5. Click on sign in button
6. Verify that "not page found" is not displayed before navigating to the concierge report -> Add this step
7. Verify that the app navigates to the correct concierge report and no duplicate concierge report are created

[joekaufmanexpensify]

Great, thanks! I'll finish up the checklist asap.

[Talha345]

@joekaufmanexpensify Payment is due!

[joekaufmanexpensify]

This bug is actually already covered by the regression test listed above, so no action is needed for the test here. I expect that's how we caught this in the first place.

[joekaufmanexpensify]

All set to issue payment here. This one qualifies for a speed bonus, so we need to issue the following payments:

• @Talha345 - $750 ($500 for PR and $250 speed bonus). Paid via Upwork.
• @fedirjh - $750 ($500 for C+ and $250 speed bonus). Paid via Upwork.

[joekaufmanexpensify]

@Talha345 $750 sent and contract ended!

[joekaufmanexpensify]

@fedirjh $750 sent and contract ended!

[joekaufmanexpensify]

Upwork job closed.

[joekaufmanexpensify]

Bug is fixed, BZ checklist is complete, and all payment issued. Closing as this is all set, thanks everyone!