Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web - App focus on compose box even when edit message is present #26319

Open
1 of 6 tasks
kbecciv opened this issue Aug 30, 2023 · 6 comments
Open
1 of 6 tasks

Web - App focus on compose box even when edit message is present #26319

kbecciv opened this issue Aug 30, 2023 · 6 comments
Assignees

Comments

@kbecciv
Copy link

kbecciv commented Aug 30, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the app
  2. Open any report
  3. Send any message
  4. Edit the message
  5. Visit any other report
  6. Revisit report opened in step 2

Expected Result:

App should keep the focus on edit message

Actual Result:

App shifts the focus on main compose box even when report has ongoing edit message

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.59.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

focus.on.main.compose.even.when.edit.message.mp4
Recording.4090.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693420650403989

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Aug 30, 2023
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Aug 30, 2023

Triggered auto assignment to @stitesExpensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@hannojg
Copy link
Contributor

hannojg commented Aug 30, 2023

I think that might be introduced by

just not sure if its really a deploy blocker? [app functionality remains imo]

@luacmartins
Copy link
Contributor

Yea, I agree this is NAB. Removing the label.

@luacmartins luacmartins removed the DeployBlockerCash This issue or pull request should block deployment label Aug 30, 2023
@stitesExpensify
Copy link
Contributor

@hannojg should I assign this to you since it's related to that other PR?

@melvin-bot melvin-bot bot added the Overdue label Sep 4, 2023
@stitesExpensify stitesExpensify added the Weekly KSv2 label Sep 5, 2023
@melvin-bot melvin-bot bot removed the Overdue label Sep 5, 2023
@melvin-bot melvin-bot bot added the Overdue label Sep 11, 2023
@stitesExpensify stitesExpensify removed their assignment Sep 13, 2023
@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Sep 13, 2023
@hannojg
Copy link
Contributor

hannojg commented Oct 20, 2023

I am not sure if this really needs to be fixed?

@melvin-bot melvin-bot bot removed the Overdue label Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants