[HOLD for payment 2023-09-08] [HOLD for payment 2023-09-07] [$500] Web - Sign in - "Abracadabra, you are signed in!" page is displayed in chat conversation

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Log out of the account
2. Enter the email on the email field and continue
3. Navigate to the email inbox and look for the magic link email
4. Change the link to staging if needed
5. Open a new tab and paste the link in the URL
6. Verify an "Abracadabra, you are signed in!" page is displayed in entire page

Expected Result:

"Abracadabra, you are signed in!" page is displayed in entire page

Actual Result:

"Abracadabra, you are signed in!" page is displayed in chat conversation

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.60.1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.4129.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause - Automation Team
Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01af75b23e8aefa481
• Upwork Job ID: 1697320264137629696
• Last Price Increase: 2023-08-31
• Automatic offers:
• jjcoffee | Reviewer | 26440465
• situchan | Contributor | 26440466

[kbecciv]

Team is not able to reproduce in Production.

Recording.4131.mp4

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @arosiclair (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[GItGudRatio]

P.S: I'm available to create a PR right away within 30 mins.

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Abracadabra, you are signed in!" page is displayed in chat conversation.

What is the root cause of that problem?

This is a regression from #22437. We do not pass the options to render the screen on the whole page, which ends up the page being displayed in the area for reports.

What changes do you think we should make in order to solve the problem?

We need to add ...screenOptions.fullScreen here:

App/src/libs/Navigation/AppNavigator/AuthScreens.js

Lines 242 to 245 in 2460704

	options={{
	headerShown: false,
	title: 'New Expensify',
	}}

What alternative solutions did you explore? (Optional)

N/A

[GItGudRatio]

Note: My above mentioned proposal changes the design slightly. I don't think this is a bug issue but would still like @shawnborton's 🟢 on this:

Prod

After Patch

If required, we can change the design as well by creating a new option altogether in getRootNavigatorScreenOptions.js

[mountiny]

@GItGudRatio I think that is fine, can you please make the PR?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01af75b23e8aefa481

[melvin-bot]

Triggered auto assignment to @adelekennedy (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[GItGudRatio]

PR is up! Kindly review, @jjcoffee @arosiclair @mountiny.

[situchan]

I can do expedite review if @jjcoffee is already off work today

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.60-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] fix: full screen abracadabra #26427

If no regressions arise, payment will be issued on 2023-09-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @GItGudRatio requires payment
• @situchan requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.61-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] fix: full screen abracadabra #26427

If no regressions arise, payment will be issued on 2023-09-08. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @GItGudRatio requires payment
• @situchan requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[luacmartins]

I believe we're just missing payments

[adelekennedy]

Payouts due:

Issue Reporter: N/A
Contributor: $500 @GItGudRatio (Upwork)
Contributor+: $500 @situchan (Upwork)

Eligible for 50% #urgency bonus? Y

Upwork job is here.

[adelekennedy]

@GItGudRatio will you apply here?

[GItGudRatio]

@adelekennedy applied, thank you!

[luacmartins]

Still processing payments

[situchan]

I think I haven't received 50% bonus.
@adelekennedy can you check please?

[GItGudRatio]

I think I haven't received 50% bonus.

Me too!

[adelekennedy]

Yikes - sorry this is what happens when you try to clean up issues fast while ooo - adding the $250bonus for you both