Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Request Money - The currency search field fails to auto-focus #27100

Closed
2 of 6 tasks
kbecciv opened this issue Sep 10, 2023 · 8 comments
Closed
2 of 6 tasks

[$500] Request Money - The currency search field fails to auto-focus #27100

kbecciv opened this issue Sep 10, 2023 · 8 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@kbecciv
Copy link

kbecciv commented Sep 10, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open a chat.
  2. Navigate to the "Request Money" section.
  3. Click on the currency option
  4. Observe that the search field does not auto-focus.

Expected Result:

The currency search field should automatically focus upon clicking, ready for user input

Actual Result:

The currency search field does not auto-focus upon clicking, resulting in the need for click on search field

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1,3,66,3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

screen-recording-2023-08-08-at-124724-am_GEID1RaT.mp4
Recording.4358.mp4

Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691438190303789

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01885f56507c4e1e91
  • Upwork Job ID: 1700780208323342336
  • Last Price Increase: 2023-09-10
@kbecciv kbecciv added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 10, 2023
@melvin-bot melvin-bot bot changed the title Request Money - The currency search field fails to auto-focus [$500] Request Money - The currency search field fails to auto-focus Sep 10, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 10, 2023

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Sep 10, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01885f56507c4e1e91

@melvin-bot
Copy link

melvin-bot bot commented Sep 10, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 10, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 10, 2023

Triggered auto assignment to @mallenexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Sep 10, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (External)

@akinwale
Copy link
Contributor

akinwale commented Sep 10, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

The currency search field fails to autofocus.

What is the root cause of that problem?

The selection list gains focus after the text input is initially focused which triggers a blur on the text input.

What changes do you think we should make in order to solve the problem?

Add shouldDelayFocus prop to the OptionsSelector in IOUCurrencySelection.

What alternative solutions did you explore? (Optional)

None.

@ishpaul777
Copy link
Contributor

Dupe of #27030

@mallenexpensify
Copy link
Contributor

Closing as it appears to be a dupe of the below. Thanks @ishpaul777 for the 👀 and comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

6 participants