[$500] Android - Payment input is not focused when tab changes from distance

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open any report
2. Request money
3. Click on distance button in the header
4. Get back to manual tab
5. Observe amount input is not focused

Expected Result:

The amount input should be focused

Actual Result:

The amount input is not focused

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.66.3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

WhatsApp.Video.2023-09-05.at.21.26.41.1.mp4

Screen_Recording_20230910_172514_New.Expensify.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Krishna2323
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693937933243989

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012a3b18dcf1980e91
• Upwork Job ID: 1700984379527847936
• Last Price Increase: 2023-09-10
• Automatic offers:
• Krishna2323 | Contributor | 26690007
• Krishna2323 | Reporter | 26690010

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012a3b18dcf1980e91

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @zanyrenney (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 (External)

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Android - Payment input is not focused when tab changes from distance

What is the root cause of that problem?

Upon investigation, the root cause appears to be the default behavior of the TopTab.Navigator. Without explicit configuration, the navigator might interfere with the keyboard's display settings, leading to its unintended dismissal or erratic behavior, especially when switching tabs or interacting with input fields.

What changes do you think we should make in order to solve the problem?

To counteract this issue, we should modify our TopTab.Navigator configuration by setting the keyboardDismissMode property to "none". This would ensure that the keyboard remains consistent in its behavior, regardless of interactions within the navigator.

By applying this change, we will override the default behavior and prevent the keyboard from dismissing due to tab interactions.

[melvin-bot]

@alexpensify, @narefyev91 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[alexpensify]

@narefyev91 will the recent proposal work to resolve this issue? Thanks!

[narefyev91]

@alexpensify Yes this will work - but should we really force it for all platforms? The issue happened only for Android - also as i see there are some open issues in react-navigation which currently exists for a long time (seems no one plan to fix them - lol)
react-navigation/react-navigation#10397
react-navigation/react-navigation#11128
satya164/react-native-tab-view#1181
Based on the suggestion to make it working - either remove animation or force keyboard to stay with keyboardDismissMode
In case this is the first tab navigator in app - we can resolve that issue with keyboardDismissMode as @Krishna2323 suggested
🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @Gonals, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @Krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @Krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[Krishna2323]

@narefyev91 @Gonals, I'm sorry for the confusion, I'm already assigned to this issue with the same solution applied to same component. I can fix this in the same PR, you can close this or put this on hold if think. There is still minor change is required for this but it can be done in that PR.

[Gonals]

Closing this, then!