[HOLD for payment 2023-10-31] Web - Login - Chat report loads infinitely with /undefined URL when logging in with a new account

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.88-3

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Sign up and log in

Expected Result:

Chat will open

Actual Result:

The chat report loads infinitely with /undefined URL

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS : Chrome
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Bug6245637_1697904738471.bandicam_2023-10-21_19-39-08-874__1_.1.mp4

MacOS: Desktop

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @Li357 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[thienlnam]

Taking this over so we can deploy monday morning

[thienlnam]

For some reason, reverting #29893 still gets you to an /undefined page but it doesn't load forever.

There still seems to be another thing that is making it so that on log in it defaults to undefined

[thienlnam]

Found the PR that caused this regression #29739

[MitchExpensify]

Anything needed from me here @thienlnam ?

[mountiny]

worked

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.89-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Add handling for undefined route #30141

If no regressions arise, payment will be issued on 2023-10-31. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@thienlnam] The PR that introduced the bug has been identified. Link to the PR:
• [@thienlnam] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@thienlnam] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@thienlnam] Determine if we should create a regression test for this bug.
• [@thienlnam] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mallenexpensify]

Was hoping this fix might also fix

• [$1000] Desktop-"Hmm.. it's not here" page appears when the app auto closes to update #28495

But it didn't. I'm still getting crashes after NewDot desktop updates. Not sure if related, consider this post more for reference

[melvin-bot]

Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MitchExpensify]

Reassigning as I'm OOO

[sophiepintoraetz]

@MitchExpensify - can you please summarise what needs to happen here?

[MitchExpensify]

We'll just need to do a payout of the C+ that reviewed the fix (@allroundexperts)

Just this on the 31st, I'll take this back as I'm back from vacay now 👍

[melvin-bot]

@thienlnam, @MitchExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[thienlnam]

Looks like tis is ready for payment!

[MitchExpensify]

Payment summary:

• C+ review $500 to @allroundexperts via NewDot

[JmillsExpensify]

$500 payment approved for @allroundexperts based on comment above.