[$250] Split - No spacing between username + email address and split amount on confirmation page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.74-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• User has long email address

1. Go to staging.new.expensify.com
2. Open a chat with user that also has long email address
3. Click + > Split expense
4. Enter amount > Next

Expected Result:

There should be some spacing between username + email address and the split amount (production behavior) on the confirmation page

Actual Result:

There is no spacing between username + email address and the split amount on the confirmation page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6481506_1715771313706.split_spacing.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b8b1885e9bbd36c6
• Upwork Job ID: 1790789501118193664
• Last Price Increase: 2024-05-15

Issue Owner

Current Issue Owner: @allroundexperts

[melvin-bot]

Triggered auto assignment to @danieldoglas (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:

1. If you find which PR caused the issue/bug, you can reassign it to the person responsible for it.
   • If the author is OOO or won’t get online before the daily deploy is due, you are responsible for finding the best fix/path forward. Don’t hesitate to ask for help!
2. Try to reproduce the issue, if the bug is on production, remove the DeployBlocker label but stay assigned to fix it (or find out which PR broke it to get help from the author).
   • You can adjust the urgency of the issue to better represent the gravity of the bug.
   • If the issue is super low priority, feel free to un-assign yourself.
   • Be careful with PHP warnings, sometimes it is more complex than just adding a null coalescing operator as they might be uncovering some bigger bug.
   • If it was a one-off issue that requires no action (for example, Bedrock was down or it is a duplicated issue), you can close it.

Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@danieldoglas FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-split

[srikarparsi]

This does look external, adding the label

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b8b1885e9bbd36c6

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[samilabud]

It doesn't seem to be happening in the current main branch (only in staging):

dev.vs.staging.test.mov

[srikarparsi]

Hm that's true, the cause looks like it comes from this PR (not sure) but trying to find what PR might've fixed it so that we can CP it.

[srikarparsi]

Ah it was this PR which fixed it. It's a pretty big PR so I'm not sure if CPing it is worth it since it might create new blockers. This is a pretty small issue so I think it might be better to just wait until QA finishes for the PR. Will check internally.

[srikarparsi]

Removing the deploy blocker as per this discussion. Will wait for this PR to hit staging and will check back.

[melvin-bot]

@danieldoglas, @allroundexperts, @srikarparsi Eep! 4 days overdue now. Issues have feelings too...

[srikarparsi]

Still waiting on the merge freeze for this PR to hit staging. Removing overdue label

[srikarparsi]

The PR hit staging and it looks good now. Closing this out.