Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Workspace - Keyboard is flickering when entering magic code at bank account flow #43425

Open
1 of 6 tasks
lanitochka17 opened this issue Jun 10, 2024 · 53 comments
Open
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause

Comments

@lanitochka17
Copy link

lanitochka17 commented Jun 10, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.81-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #38726

Action Performed:

  1. Log in with a new Gmail account
  2. Create a workspace
  3. Enable "Workflows"
  4. Navigate to Workflows - Connect bank account
  5. Tap on "verify your account here"
  6. Enter magic code

Expected Result:

The keyboard shouldn't flicker

Actual Result:

Keyboard is flickering when entering or deleting magic code at bank account flow for an unverified account. The text under is becomes visible for a very short time

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6508507_1718045416240.PQTM0868.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01bfdc76c99fb63dcf
  • Upwork Job ID: 1800283124607224669
  • Last Price Increase: 2024-08-08
Issue OwnerCurrent Issue Owner: @abdulrahuman5196
@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API labels Jun 10, 2024
Copy link

melvin-bot bot commented Jun 10, 2024

Triggered auto assignment to @roryabraham (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

@roryabraham FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@lanitochka17
Copy link
Author

We think that this bug might be related to #wave-collect - Release 1

@roryabraham
Copy link
Contributor

I've been seeing this one for a while, so I'm pretty sure it's not a deploy blocker. It is really annoying though.

@roryabraham
Copy link
Contributor

roryabraham commented Jun 10, 2024

I think there are some other preconditions we're missing that makes this happen, because I wasn't able to reproduce this on staging with my rory@expensify.com account. But I've seen it before.

@roryabraham
Copy link
Contributor

It happens with some other TextInputs too... 🤔

@roryabraham
Copy link
Contributor

roryabraham commented Jun 10, 2024

It looks similar to this Flutter issue

edit: found the similar React Native issue: facebook/react-native#39411

@roryabraham
Copy link
Contributor

It sounds like the consensus in the community is that this is an iOS 17 issue, which is out of our hands.

@roryabraham
Copy link
Contributor

roryabraham commented Jun 10, 2024

We may be able to disable auto suggestions for the MagicCode input, by setting it to a oneTimePassword input, which seems appropriate. But I'm not sure if that will disable this autocompletion behavior (shows up after opening the email with the magic code)

Edit: Already has oneTimeCode

@roryabraham
Copy link
Contributor

Since I'm pretty certain I've seen this in production, and I'm not consistently seeing it in staging, I'm going to demote it.

I'll make it external just in case I'm being too hasty in thinking that it's most likely an iOS bug, and someone has a simple idea to fix this.

@roryabraham roryabraham added Daily KSv2 Hourly KSv2 External Added to denote the issue can be worked on by a contributor and removed Hourly KSv2 DeployBlockerCash This issue or pull request should block deployment Daily KSv2 DeployBlocker Indicates it should block deploying the API labels Jun 10, 2024
Copy link

melvin-bot bot commented Jun 10, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01bfdc76c99fb63dcf

@melvin-bot melvin-bot bot changed the title Workspace - Keyboard is flickering when entering magic code at bank account flow [$250] Workspace - Keyboard is flickering when entering magic code at bank account flow Jun 10, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 10, 2024
Copy link

melvin-bot bot commented Jun 10, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

@roryabraham roryabraham removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 10, 2024
@melvin-bot melvin-bot bot added Overdue and removed Weekly KSv2 labels Aug 8, 2024
Copy link

melvin-bot bot commented Aug 9, 2024

This issue has not been updated in over 15 days. @kevinksullivan, @abdulrahuman5196, @roryabraham, @lanitochka17 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Overdue labels Aug 9, 2024
@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@kevinksullivan
Copy link
Contributor

Looping in a BZ member to handle payment as I'm going OOO in case this does get picked up

@melvin-bot melvin-bot bot added the Overdue label Sep 12, 2024
@kevinksullivan kevinksullivan removed Overdue Bug Something is broken. Auto assigns a BugZero manager. labels Sep 12, 2024
@melvin-bot melvin-bot bot added the Overdue label Sep 12, 2024
@kevinksullivan kevinksullivan removed their assignment Sep 12, 2024
@melvin-bot melvin-bot bot removed the Overdue label Sep 12, 2024
@kevinksullivan kevinksullivan added the Bug Something is broken. Auto assigns a BugZero manager. label Sep 12, 2024
Copy link

melvin-bot bot commented Sep 12, 2024

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Monthly KSv2 labels Sep 12, 2024
@kevinksullivan kevinksullivan self-assigned this Sep 12, 2024
@mvtglobally
Copy link

Issue not reproducible during KI retests. (Second week)

@slafortune
Copy link
Contributor

SO If KI restest are not reproducible for more than 3 weeks it's safe to close the GH - one more week of testing 👍

Copy link

melvin-bot bot commented Sep 16, 2024

@slafortune, @kevinksullivan, @abdulrahuman5196, @roryabraham, @lanitochka17 Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Sep 16, 2024
@abdulrahuman5196
Copy link
Contributor

SO If KI restest are not reproducible for more than 3 weeks it's safe to close the GH - one more week of testing 👍

Same

@melvin-bot melvin-bot bot removed the Overdue label Sep 17, 2024
Copy link

melvin-bot bot commented Sep 20, 2024

@slafortune, @kevinksullivan, @abdulrahuman5196, @roryabraham, @lanitochka17 Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Sep 20, 2024
@slafortune
Copy link
Contributor

slafortune commented Sep 23, 2024

Unassigning myself now that you're back @kevinksullivan - just needs to be tested once more.

@slafortune slafortune removed their assignment Sep 23, 2024
@melvin-bot melvin-bot bot removed the Overdue label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause
Projects
Status: Polish
Development

No branches or pull requests

9 participants