-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$500] Workspace - Keyboard is flickering when entering magic code at bank account flow #43425
Comments
Triggered auto assignment to @roryabraham ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
@roryabraham FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
We think that this bug might be related to #wave-collect - Release 1 |
I've been seeing this one for a while, so I'm pretty sure it's not a deploy blocker. It is really annoying though. |
I think there are some other preconditions we're missing that makes this happen, because I wasn't able to reproduce this on staging with my rory@expensify.com account. But I've seen it before. |
It happens with some other TextInputs too... 🤔 |
It looks similar to this Flutter issue edit: found the similar React Native issue: facebook/react-native#39411 |
It sounds like the consensus in the community is that this is an iOS 17 issue, which is out of our hands. |
We may be able to disable auto suggestions for the MagicCode input, by setting it to a oneTimePassword input, which seems appropriate. But I'm not sure if that will disable this autocompletion behavior (shows up after opening the email with the magic code) Edit: Already has |
Since I'm pretty certain I've seen this in production, and I'm not consistently seeing it in staging, I'm going to demote it. I'll make it external just in case I'm being too hasty in thinking that it's most likely an iOS bug, and someone has a simple idea to fix this. |
Job added to Upwork: https://www.upwork.com/jobs/~01bfdc76c99fb63dcf |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 ( |
This issue has not been updated in over 15 days. @kevinksullivan, @abdulrahuman5196, @roryabraham, @lanitochka17 eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
Issue not reproducible during KI retests. (First week) |
Looping in a BZ member to handle payment as I'm going OOO in case this does get picked up |
Triggered auto assignment to @slafortune ( |
Issue not reproducible during KI retests. (Second week) |
SO If KI restest are not reproducible for more than 3 weeks it's safe to close the GH - one more week of testing 👍 |
@slafortune, @kevinksullivan, @abdulrahuman5196, @roryabraham, @lanitochka17 Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Same |
@slafortune, @kevinksullivan, @abdulrahuman5196, @roryabraham, @lanitochka17 Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Unassigning myself now that you're back @kevinksullivan - just needs to be tested once more. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.81-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Issue found when executing PR #38726
Action Performed:
Expected Result:
The keyboard shouldn't flicker
Actual Result:
Keyboard is flickering when entering or deleting magic code at bank account flow for an unverified account. The text under is becomes visible for a very short time
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6508507_1718045416240.PQTM0868.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @abdulrahuman5196The text was updated successfully, but these errors were encountered: