Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenOldDotLink API command is called when opening NewDot in the new tab #43433

Closed
1 of 6 tasks
m-natarajan opened this issue Jun 10, 2024 · 12 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Needs Reproduction Reproducible steps needed retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause Weekly KSv2

Comments

@m-natarajan
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number:
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @puneetlath
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1718033908632569

Action Performed:

  1. Open staging.new.expensify.com
  2. Open the same link in the new tab and look at the API calls

Expected Result:

Since the ND is not opened from an olddot link API should not call OpenOldDotLink

Actual Result:

OpenOldDotLink is called

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

image (1)

View all open jobs on GitHub

@m-natarajan m-natarajan added Daily KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. labels Jun 10, 2024
Copy link

melvin-bot bot commented Jun 10, 2024

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@MelvinBot
Copy link

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

@carlosmiceli
Copy link
Contributor

@VictoriaExpensify are you working on this? If not I'll take it.

@VictoriaExpensify
Copy link
Contributor

Hey @carlosmiceli - this is all yours, have fun!

@carlosmiceli carlosmiceli added the retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause label Jun 11, 2024
@carlosmiceli
Copy link
Contributor

carlosmiceli commented Jun 11, 2024

Couldn't reproduce, and others here couldn't reproduce either. Will close for now since it doesn't seem like a big issue, can take this on again if bug re-appears.

@carlosmiceli carlosmiceli removed the retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause label Jun 11, 2024
@carlosmiceli carlosmiceli reopened this Jun 11, 2024
@carlosmiceli carlosmiceli added the retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause label Jun 11, 2024
@carlosmiceli
Copy link
Contributor

Haven't been able to reproduce, will try with @puneetlath live later this week.

@carlosmiceli carlosmiceli added Weekly KSv2 and removed Daily KSv2 labels Jun 13, 2024
@melvin-bot melvin-bot bot added the Overdue label Jun 21, 2024
@carlosmiceli
Copy link
Contributor

Still being tested.

@melvin-bot melvin-bot bot removed the Overdue label Jun 21, 2024
Copy link

melvin-bot bot commented Jun 24, 2024

@carlosmiceli this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@carlosmiceli
Copy link
Contributor

Yes, we're close to closing it.

@melvin-bot melvin-bot bot added the Overdue label Jul 2, 2024
@carlosmiceli
Copy link
Contributor

@muttmuure Matt, do you think we can close this one? Seems like no updates or repeated occurrences...

@melvin-bot melvin-bot bot removed the Overdue label Jul 2, 2024
@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@puneetlath
Copy link
Contributor

Let's close for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Needs Reproduction Reproducible steps needed retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause Weekly KSv2
Projects
Development

No branches or pull requests

6 participants