[HOLD for payment 2024-06-28] [$250] Don't show "We might have a problem. Check out "

[srikarparsi]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
**Slack conversation:https://expensify.slack.com/archives/C05LX9D6E07/p1717834594513299

Action Performed:

1. In Network devtools, verify that Ping command is called every 60 seconds (see Network Devtools)
2. Block https://dev.new.expensify.com:8082/api request to make backend unreachable (see Block network request)
3. Verify that after a while, 'You appear to be offline.' message appears.

Expected Result:

We should only ever see the 'You appear to be offline.' message

Actual Result:

Sometimes, we see the 'We might have a problem. Check out status.expensify.com.' message

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• [ x] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01557bbba5e2f56091
• Upwork Job ID: 1800772528715909319
• Last Price Increase: 2024-06-12

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01557bbba5e2f56091

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[srikarparsi]

Essentially, we need to revert this PR without altering future changes made to networking like this PR. @tienifr @DylanDylann @cubuspl42 if you could take a look at this, that would be great since you worked on the original PR to add in this functionality.

[tienifr]

@srikarparsi Sure, I can work on this. Feel free to assign me and @DylanDylann (who reviewed the PR) to this issue 🙏

[DylanDylann]

@tienifr Please ping me when the PR is ready

[srikarparsi]

Cool thanks, @mananjadhav reassigning to @DylanDylann since he reviewed the initial PR.

[melvin-bot]

❌ There was an error making the offer to @DylanDylann for the Contributor role. The BZ member will need to manually hire the contributor.

[melvin-bot]

❌ There was an error making the offer to @DylanDylann for the Reviewer role. The BZ member will need to manually hire the contributor.

[melvin-bot]

❌ There was an error making the offer to @tienifr for the Contributor role. The BZ member will need to manually hire the contributor.

[melvin-bot]

❌ There was an error making the offer to @DylanDylann for the Contributor role. The BZ member will need to manually hire the contributor.

[melvin-bot]

❌ There was an error making the offer to @DylanDylann for the Reviewer role. The BZ member will need to manually hire the contributor.

[melvin-bot]

❌ There was an error making the offer to @tienifr for the Contributor role. The BZ member will need to manually hire the contributor.

[srikarparsi]

Not sure why the automation is failing. @tienifr do you think you can give an ETA for when the PR will be ready?

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.0-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Revert: Backend unreachability message #43888

If no regressions arise, payment will be issued on 2024-06-28. 🎊

For reference, here are some details about the assignees on this issue:

• @tienifr requires payment (Needs manual offer from BZ)
• @DylanDylann requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@DylanDylann] The PR that introduced the bug has been identified. Link to the PR:
• [@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@DylanDylann] Determine if we should create a regression test for this bug.
• [@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @tienifr owed $250 via NewDot
• ROLE: @DylanDylann paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@trjExpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1800772528715909319/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[trjExpensify]

👋 checklist time!

[trjExpensify]

Bump on the checklist, @DylanDylann!

[DylanDylann]

This is a reverted PR. We don't need the checklist.

[DylanDylann]

This is a reverted PR. We don't need the checklist.

cc @srikarparsi

[trjExpensify]

Oh cool, so no payment is due as it was a regression revert?

[DylanDylann]

@trjExpensify The payment should be handled here because this is not a regression. we intended to implement this feature previously but it seems this is unnecessary so the internal team created this issue as a task to revert the previous PR

cc @srikarparsi

[trjExpensify]

Alright cool, gotcha. Payment summary as follows:

• $250 to @DylanDylann for the C+ review
• $250 to @tienifr for the fix

I checked in TestRail, and there isn't a regression test for this scenario of the site being down to delete, so we're good there.

Offers sent!

[tienifr]

$250 to @tienifr for the fix

Thanks, I've requested on NewDot

[DylanDylann]

@trjExpensify I accepted the Upwork offer 🙏

[trjExpensify]

Paid, @DylanDylann. Closing!

[JmillsExpensify]

$250 approved for @tienifr