-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] [Search v2.2] Redirected back to "Expenses" when refreshing the page while in "chats" #48817
Comments
Triggered auto assignment to @NikkiWines ( |
Triggered auto assignment to @johncschuster ( |
We think that this bug might be related to #wave-control |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
I can take this since it's part of Search |
Job added to Upwork: https://www.upwork.com/jobs/~021833265839061428544 |
Current assignee @ikevin127 is eligible for the External assigner, not assigning anyone new. |
This also happens with the current data types, e.g. Invoice, Trips. We don't currently store the context of the Search query when viewing the item in the RHP. Demoting to NAB. @Kicu @WojtekBoman |
Yup it is quite clear why this behaviour happens, based on how search + navigation works. I think we'd need to think a bit how best to improve this behaviour if we want to. In general we are basing the whole state of search on current But this also means behaviours like this one, where if we don't have query in URL then we loose the previous state. I'm a bit reluctant to change this behaviour for now. 🤔 |
I agree, but I think that's something we'll eventually have to do to allow for a better navigation experience. We don't need to rush though and can think more carefully on how to solve this without creating bugs. |
Thanks for the thoughtful discussion @Kicu and @luacmartins! What's the next step here? Do we need to take this to Slack to discuss in more detail? |
@Kicu let me know if you or someone at SWM can take on this issue. |
@luacmartins but what is the expectation. I described that this is kinda complex and we should think about how to best solve it. Then you agreed. |
Oh I just meant to take this on and investigate a good holistic solution for this. Let's not rush this one |
Alright makes sense. |
❌ There was an error making the offer to @ikevin127 for the Reviewer role. The BZ member will need to manually hire the contributor. |
@Kicu, @johncschuster, @luacmartins, @ikevin127 Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Not overdue, this is being worked on. |
I will have some update on this issue today or tomorrow, I was handling some other search tasks last week |
@luacmartins Correctly set and handled I should have the PR ready tomorrow, it will be relatively small so I can do it in between other 2.4 tasks |
@Kicu @johncschuster @luacmartins @ikevin127 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
calm down melvin ☮️ this will have a PR opened today |
PR is open for review |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v9.0.31-0
Reproducible in staging?: Y
Reproducible in production?: N/A
Email or phone of affected tester (no customers): applausetester+shsb22ertt@applause.expensifail.com
Issue reported by: Applause Internal Team
Action Performed:
Expected Result:
App stays in "Chat" search type
Actual Result:
App navigates to "Expense" search type in the background while the RHP of the report view is still opened
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6597783_1725902417521.2024-09-09_19_16_26.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @Issue Owner
Current Issue Owner: @KicuThe text was updated successfully, but these errors were encountered: