[$250] Android & iOS - Spend category - Unable to select category when keyboard is up

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.31-12
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Launch New Expensify app.
2. Go to workspace chat.
3. Start a manual expense flow.
4. On confirmation page, tap Category.
5. With keyboard up, tap on any category.
6. Note that the category can be selected when keyboard is up.
7. Go to workspace settings > Categories.
8. Click Settings.
9. Click on any spend.
10. With keyboard up, tap on any category.

Expected Result:

User should be able to select any category when keyboard is up (also this is mweb behavior).

Actual Result:

The keyboard is dismissed and the category is not selected when keyboard is up.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6598321_1725945441300.ScreenRecording_09-10-2024_13-09-39_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021836880412171065631
• Upwork Job ID: 1836880412171065631
• Last Price Increase: 2024-09-19

Issue Owner

Current Issue Owner: @rayane-djouah

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

We think that this bug might be related to #wave-control

[IuliiaHerets]

@mallenexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[dominictb]

Edited by proposal-police: This proposal was edited at 2024-09-11 06:25:47 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

• The keyboard is dismissed and the category is not selected when keyboard is up.

What is the root cause of that problem?

• We already set prop keyboardShouldPersistTaps="always" in here, and it works in case of category page in step 5 in OP.

• But in step 10, the BaseSelectionList component is wrapped inside another ScrollView component:

App/src/pages/workspace/categories/WorkspaceCategoriesSettingsPage.tsx

Line 103 in 762bffc

<ScrollView>{listItems}</ScrollView>

so the keyboardShouldPersistTaps="always" does not work anymore. The same issue is reported here.

What changes do you think we should make in order to solve the problem?

• We can update:
  

  App/src/pages/workspace/categories/WorkspaceCategoriesSettingsPage.tsx

  Line 103 in 762bffc

  <ScrollView>{listItems}</ScrollView>

  
  to:

                            <ScrollView keyboardShouldPersistTaps="always">{listItems}</ScrollView>

• The same fix can be applied to another page that use category picker as modal.

What alternative solutions did you explore? (Optional)

[mallenexpensify]

OOO til Tues, will revisit/review once back. If anyone thinks this can't wait til then, post in #expensify-open-source to get 👀 and another BZ assigned.

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[mallenexpensify]

Not reproducible on iOS, Safari, production.

@dominictb , if you're able to repro, can you please provide details? Thx

RPReplay_Final1726599745.MP4

[dominictb]

@mallenexpensify I can reproduce it in latest main on IOS Native:

1. Go to workspace settings > Categories.
2. Click Settings.
3. Click on any spend.
4. With keyboard up, tap on any category.
5. The keyboard is dismissed and the category is not selected when keyboard is up.

Screen.Recording.2024-09-18.at.02.16.24.mov

[mallenexpensify]

What version are you on @dominictb ? I was unable to repro on staging, v9.0.36-1

RPReplay_Final1726609619.MP4

[dominictb]

What version are you on @dominictb ? I was unable to repro on staging, v9.0.36-1

I can't reproduce this issue on staging/production because my account doesn't have access to that feature. I need to use the dev version to mock and access all the beta features.

[dominictb]

@mallenexpensify Please note, the "step 4. With keyboard up, tap on any category." in my reproduce steps is very important.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021836880412171065631

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)

[mallenexpensify]

I'm guessing this can likely be External then. @rayane-djouah , can you attempt reproduction? Thx

[rayane-djouah]

Will review this in my morning 👍

[rayane-djouah]

@mallenexpensify I can't reproduce this. The bug has been fixed in #49030

[mallenexpensify]

gonna throw retest-weekly on here, assuming QA can't reproduce, I'll close.

[melvin-bot]

@mallenexpensify @rayane-djouah this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!