[$250] [Workspace Feeds] There's no checkmark next to the current settlement account being used.

[trjExpensify]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.31-24
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @kevinksullivan
Slack conversation: https://expensify.slack.com/archives/C036QM0SLJK/p1725977031984379

Action Performed:

1. Enable the Expensify Card
2. Click Settings at the top of the Expensify Card page
3. Click Settlement account

Expected Result:

The bank account being used should be highlighted with a checkmark

Actual Result:

There's no checkmark against the bank account being used for settlements.

Note: We also want to make sure we refactor the Wallet > Transfer Balance screen to use this same select list styling, as right now it has radio buttons, so let's make it consistent:

Workaround:

N/A, visual design bug.

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

See above in-line.

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021836004132424001151
• Upwork Job ID: 1836004132424001151
• Last Price Increase: 2024-09-17

[melvin-bot]

Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.

[trjExpensify]

Someone on the Workspace Feeds team will take this, looking for who's available.

[koko57]

I can work on this issue

[trjExpensify]

Thanks!

[koko57]

With the non-checked bank account problem - same root cause as in #48943 (comment) - we don't have bankAccountID in the accountData object - after OpenPaymentsPage we have this data so the bank account is properly checked.
We have methodID instead, so I will check for both bankAccountID and methodID.

@trjExpensify just to make sure: we're talking of changing the Wallet > Transfer Balance page to use the same design as Settlement Account page (not the way around?) - list items instead of radio buttons?

[DylanDylann]

@trjExpensify just to make sure: we're talking of changing the Wallet > Transfer Balance page to use the same design as Settlement Account page (not the way around?) - list items instead of radio buttons?

I see we have 2 tasks here:

• Always display highlight checkmark on the selected option
• we could update to align PaymentMethodList Component and use it in all places for consistency. @koko57 Wdyt?

[DylanDylann]

@allgandalf I will take this one

[allgandalf]

HEROOOOOO @DylanDylann 🙇🦸

[koko57]

@DylanDylann yeah, I know we have 2 😅 I was just asking - do we want checkmarks or radio buttons? But I understand we're going with Select List not Radio Buttons 😄

[DylanDylann]

But I understand we're going with Select List not Radio Buttons 😄

I have the same thoughts with you

Anyways, It shouldn't block creating PR, we can get a confirmation on the PR phase

[koko57]

@DylanDylann yep, on it. I'm doing 1000 things at once, but I should be able to open the PR for that til EOD 😅

[DylanDylann]

Ops. @koko57 I can help raise a PR early on Friday morning if you are busy (and you can help review it). Stay health!

[koko57]

@DylanDylann thank you, no worries, I can do it 😃

[koko57]

@DylanDylann @trjExpensify I can open the PR for fixing the checkmark, but for this design change I would rather open a separate PR - I can do it under its issue, but a separate would be better. It's not just replacing one component - we're using PaymentMethodList which is also used in another location, and here for the data we have both bank accounts and cards

[koko57]

@trjExpensify @DylanDylann I'm opening the PR for review. If you decide that both task should be done in one PR I will work on it tomorrow

[trjExpensify]

@trjExpensify just to make sure: we're talking of changing the Wallet > Transfer Balance page to use the same design as Settlement Account page (not the way around?) - list items instead of radio buttons?

Yes, that's correct that we want to update the Transfer balance page to use the same selectList design as the Settlement Account. 👍

[trjExpensify]

@trjExpensify @DylanDylann I'm opening the PR for review. If you decide that both task should be done in one PR I will work on it tomorrow

By that you just mean that the update to a selectList in Wallet > Transfer Balance will come separately?

[koko57]

@trjExpensify yes, the checkmark thing is a very small change and I don't want to block it, so that's why I opened the PR.
This design change will take a bit longer, but if you want I can add this to the PR with checkmark

[trjExpensify]

Yep, sounds good! 👍

[koko57]

Great! Thanks!

[mountiny]

Are we keeping this open fo the transfer wallet page right? Or do we want to separate it into its own ticket?

[trjExpensify]

May as well just use this one.

[mountiny]

Asking in Slack if we can export this

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021836004132424001151

[melvin-bot]

Current assignees @allgandalf and @DylanDylann are eligible for the External assigner, not assigning anyone new.

[allgandalf]

PR is on staging

[allgandalf]

Other PR also got merged, fixed the issue of Virtualised lists error across application 🪂

[mountiny]

I propose $375 for this work as its 2 prs and the second pr put in place a fix with guidelines for others to avoid it so that is useful.

[allgandalf]

Fine with me 👍

[trjExpensify]

We're handling this one outside of the project, yeah?

[DylanDylann]

Am I eligible for payment?

[mountiny]

Yeah i would say $250 as the second pr was basically no qa through but it took Gandalf some time to figure it out.

[allgandalf]

Update:

• 1st PR hit production
• 2nd PR hit staging yesterday