Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing] Hold - Approve confirmation modal show full amount as full and partial option #49220

Open
3 of 6 tasks
IuliiaHerets opened this issue Sep 14, 2024 · 7 comments
Open
3 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Needs Reproduction Reproducible steps needed Weekly KSv2

Comments

@IuliiaHerets
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.0.35-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): gocemate+workspaceapprover182@gmail.com
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

  1. Login as the owner of the workspace
  2. Create a workspace
  3. Invite the approver and employee
  4. Navigate to more features
  5. Enable "workflows"
  6. On the "Workflow" editor - enable "Add Approvals"
  7. Set the Approver account as the Approver

Steps:

  1. As Employee submit 2 distance expenses to the workspace chat
  2. As Employee edit the first distance request by changing start or stop destination
  3. As Employee hold the first distance request
  4. As Approver click on green Approve button
  5. Verify confirmation modal appears

Expected Result:

Confirmation modal should show full and partial amount that should be approved

Actual Result:

Confirmation modal shows same amount (full amount as full and partial option)

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6602135_1726220780242!Capture

Recording.3940.mp4

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 14, 2024
Copy link

melvin-bot bot commented Sep 14, 2024

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@IuliiaHerets
Copy link
Author

We think that this bug might be related to #wave-collect - Release 1

@IuliiaHerets
Copy link
Author

@strepanier03 FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@melvin-bot melvin-bot bot added the Overdue label Sep 16, 2024
Copy link

melvin-bot bot commented Sep 18, 2024

@strepanier03 Whoops! This issue is 2 days overdue. Let's get this updated quick!

@strepanier03 strepanier03 added Hourly KSv2 and removed Daily KSv2 labels Sep 19, 2024
@strepanier03
Copy link
Contributor

Will prioritize this tomorrow.

@melvin-bot melvin-bot bot removed the Overdue label Sep 19, 2024
@strepanier03 strepanier03 added Daily KSv2 and removed Hourly KSv2 labels Sep 19, 2024
@strepanier03
Copy link
Contributor

I've tested this twice now and I'm unable to reproduce this.

@strepanier03 strepanier03 added the Needs Reproduction Reproducible steps needed label Sep 19, 2024
@strepanier03 strepanier03 changed the title Hold - Approve confirmation modal show full amount as full and partial option [Testing] Hold - Approve confirmation modal show full amount as full and partial option Sep 19, 2024
@strepanier03 strepanier03 added Weekly KSv2 and removed Daily KSv2 labels Sep 19, 2024
@MelvinBot
Copy link

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Needs Reproduction Reproducible steps needed Weekly KSv2
Projects
None yet
Development

No branches or pull requests

3 participants