[HOLD E/App #43588] [$50] Workspace chat - Report header shows "0.00 for Pending... @1.00 / mi" when changing distance & rate offline

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.35-4
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4966766
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

• Workspace has at least two distance rates.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Submit a distance expense.
4. Go to transaction thread.
5. Go offline.
6. Click Distance.
7. Edit the distance by swapping the waypoints.
8. Save it.
9. Click Rate.
10. Select a different rate.

Expected Result:

Report header will display "Pending" after changing distance and rate offline (production behavior).

Actual Result:

Report header displays "0.00 for Pending... @1.00 / mi" after changing distance and rate offline.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6605378_1726486914062.20240916_193630.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021835712136231108969
• Upwork Job ID: 1835712136231108969
• Last Price Increase: 2024-09-16

Issue Owner

Current Issue Owner: @s77rt

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @francoisl (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021835712136231108969

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[mountiny]

This is very minor and edge case flow with no real burden to the user, demoting

[melvin-bot]

Upwork job price has been updated to $50

[mountiny]

$50 for finding the offending PR

[CyberAndrii]

Offending PR seems to be #47136

[s77rt]

cc @paultsimura Can you check this one please

[paultsimura]

Managed to reproduce. I'll take a look in the morning.
cc: @neil-marcellini

[paultsimura]

@neil-marcellini this is one of those edge cases that I wanted to fix holistically:

1. We should split the calculateAmountForUpdatedWaypointOrRate into 2 separate functions as the logic here is gradually growing apart with every new specific test case:
   • calculateModifiedFieldsForUpdatedWaypoints
   • calculateModifiedFieldsForUpdatedDistanceRate
2. Have a proper way to determine the current unit & rate – possibly hold for [$250] Distance - Inconsistency in showing unit in preview and transaction thread after updating unit #43588 to know what way we are going: updating the BE model or parsing the merchant.

[alexpensify]

@s77rt do you agree with this plan? Thanks!

[s77rt]

@neil-marcellini is working on #43588 and this one is not a priority, holding makes sense to me

[alexpensify]

Thanks for the update. I've moved this to hold, and we can revisit it after #43588 is in production.