Android - Expense - App crashes when uploading a PDF receipt after uploading a photo receipt

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.36-1
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Email or phone of affected tester (no customers): applausetester+watashiwastar2@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Launch New Expensify app.
2. Go to FAB > Submit expense > Manual.
3. Enter amount and select a user.
4. On confirmation page, tap 3-dot menu > Add receipt.
5. Add any photo receipt from device gallery.
6. On confirmation page with the photo receipt, tap 3-dot menu > Add receipt.
7. Select Choose file.
8. Select the PDF file (attached below) (happens with this PDF file only).
9. Might need to repeat Step 4 to 8 to reproduce the crash.

Expected Result:

App will not crash.

Actual Result:

App crashes when uploading a PDF receipt after uploading a photo receipt.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1709.txt

Bug6606744_1726589183407.w_017c4be1d3a760522847c336971d21d3662a4686-2024-09-17_16_06_16.995.mp4

Bug6606744_1726588963019!International_Money_Transfer__Send_Money_Abroad_with_Wise__ex-TransferWise_.pdf

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @carlosmiceli (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

We think that this bug might be related to #wave-collect - Release 1

[grgia]

ongoing slack convos:
open-source: https://expensify.slack.com/archives/C02NK2DQWUX/p1726598780128409
deployer: https://expensify.slack.com/archives/C07J32337/p1726599054838339?thread_ts=1726595505.237429&cid=C07J32337

[mountiny]

Reopening to handle this update and fix the issue

[mountiny]

com.expensify.chat_issue_85c581edcdb39b941df627e7b1324a71_crash_session_66e8e6b7001c00016a8be1d135199580_DNE_0_v2_stacktrace.txt

--------- beginning of crash
09-17 23:58:21.532  8197  8703 E AndroidRuntime: FATAL EXCEPTION: PDF renderer
09-17 23:58:21.532  8197  8703 E AndroidRuntime: Process: com.expensify.chat, PID: 8197
09-17 23:58:21.532  8197  8703 E AndroidRuntime: java.lang.IllegalStateException: Already closed
09-17 23:58:21.532  8197  8703 E AndroidRuntime: 	at io.legere.pdfiumandroid.util.ConfigKt.handleAlreadyClosed(SourceFile:44)
09-17 23:58:21.532  8197  8703 E AndroidRuntime: 	at io.legere.pdfiumandroid.PdfPage.close(SourceFile:18)
09-17 23:58:21.532  8197  8703 E AndroidRuntime: 	at S5.J3.a(SourceFile:5)
09-17 23:58:21.532  8197  8703 E AndroidRuntime: 	at io.legere.pdfiumandroid.PdfiumCore.renderPageBitmap(SourceFile:6)
09-17 23:58:21.532  8197  8703 E AndroidRuntime: 	at x3.k.b(SourceFile:189)
09-17 23:58:21.532  8197  8703 E AndroidRuntime: 	at x3.k.handleMessage(SourceFile:7)
09-17 23:58:21.532  8197  8703 E AndroidRuntime: 	at android.os.Handler.dispatchMessage(Handler.java:106)
09-17 23:58:21.532  8197  8703 E AndroidRuntime: 	at android.os.Looper.loopOnce(Looper.java:230)
09-17 23:58:21.532  8197  8703 E AndroidRuntime: 	at android.os.Looper.loop(Looper.java:319)
09-17 23:58:21.532  8197  8703 E AndroidRuntime: 	at android.os.HandlerThread.run(HandlerThread.java:67)
09-17 23:58:21.534  8197  8197 D jniPdfium: Destroy FPDF library
09-17 23:58:21.568  1912  1912 I Layer   : Layer [Sprite#2978] hidden!! flag(1)
09-17 23:58:21.569  2632  4778 I NSLocationMonitor: getGPSUsingApps() called
09-17 23:58:21.571  4757 15254 I NSLocationManager_FLP: getGPSUsingApps, NO_FREEZE={5013} / FREEZE={10235}
09-17 23:58:21.573  1912  1912 D SurfaceFlinger: Display 4630946213010294403 HWC layers:

[mountiny]

Some logs from the crash

[mountiny]

Asked SWM to look into this

[mountiny]

@j-piasecki @blazejkustra Who is working on this one? Can they please comment so I can assign them? thanks!

[j-piasecki]

I believe @Guccio163 is currently investigating this.

[Guccio163]

That's right, I'm Wiktor Gut from SWM, please assign me this issue

[Guccio163]

Hi, I'm just letting you know that it can take a little more time, I've reproduced this bug on current main; It can be not a package, but implementation problem - there are also similar bugs reported here encountered when updating RN from 0.71 to 0.74.5

[mountiny]

Interesting, we were not able to reproduce with many tries after revert

Thanks for the update

[Guccio163]

I understand, it is really non-deterministic - sometimes it goes after 4th try and sometimes doesn't break after 20th, this is the main reason why it takes time because is hard to test 🐢