New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support appdef inheritance in dataconverter #112

Open

domna opened this issue Apr 5, 2023 · 1 comment

Labels

Contributor

domna commented Apr 5, 2023 •

edited

Loading

There is an issue
https://github.com/nomad-coe/nomad-parser-nexus/issues/35

and PR, which contains a test failing on not supported inheritance
https://github.com/nomad-coe/nomad-parser-nexus/pull/36

domna added the pre1 label

domna mentioned this issue

Check IVTemp example to make sure it correctly complains on missing inherited User group #128

Open

sanbrock added the mvp label

sanbrock changed the title ~~Support appdef inheritance in nexusutils~~ Support appdef inheritance in dataconverter

Contributor

sanbrock commented Apr 12, 2023

also note that dataconverter cuold/should write some more attributes (see NXroot and NXentry):

/@NX_class = "NXroot"
/@file_time
/@file_name
/@HDF5_Version
/@h5py_version
/@Creator
/@creator_version
/ENTRY/definition@version (!)
/ENTRY/definition@URL

Note the use of non-standard definitions (expressed in NXDL) as supported by NeXus preferably under /ENTRY/SUBENTRY/ following definitions as referenced in /ENTRY/SUBENTRY/definition_local (https://manual.nexusformat.org/classes/base_classes/NXsubentry.html#nxsubentry-definition-local-field)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment