JacksonJsonProvider has @Produces(MediaType.WILDCARD) and yet hasMatchingMediaType(MediaType.WILDCARD) return false #193
Labels
Comments
cowtowncoder
changed the title
|
Merged in 2.18 for 2.18.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
the class JacksonJaxbJsonProvider has
@Produces(MediaType.WILDCARD)but then because JacksonJaxbJsonProvider extends JacksonJsonProvider (that ALSO has
@Produces(MediaType.WILDCARD))and JacksonJsonProvider implements the method:
and so when MediaType.WILDCARD, that literally comes from the annotation (picked up here) of the very same class gets passed back into its
hasMatchingMediaType, it returns false, basically saying it cant be used to produce the very thing it says it can handle producing.so it never gets picked up in situations when it SHOULD be getting picked up.
example situation is if we want to return a random class that have nothing setup for content-type, this can happen when we are using a ErrorHandler from a lib, and the lib does not know if the service will want json or xml, so it cant specify the content-type, but it should get encoded by the default the service has setup, and this case json. but instead of trying to encode this object in json, something JacksonJaxbJsonProvider can do, it falls through to the next encoder, text and that fails.
if we change
@Produces(MediaType.WILDCARD)to@Produces(MediaType.APPLICATION_JSON)on JacksonJaxbJsonProvider then it works correctly. here is a PR demonstrating the fix: #194 (also FasterXML/jackson-jakarta-rs-providers#31)to demonstrate the issue i have made 2 exactly the same apps, one uses jackson, the other one uses jsonb
the jsonb one works, the jackson one fails
jackson_vs_jsonb.zip
to run, open both projects in intellij and then run all the tests, in the jackson one there will be one test failure
this is because the jsonb one correctly has
@Produces({"application/json", "text/json", "*/*"})on its JsonBindingProviderhere is the stack trace of it calling hasMatchingMediaType with the MediaType specified in
@Produces(MediaType.WILDCARD)resulting error in app:
The text was updated successfully, but these errors were encountered: