Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let's talk: Transformation auditing #1

Open
0xJoeMama opened this issue Apr 25, 2024 · 2 comments
Open

Let's talk: Transformation auditing #1

0xJoeMama opened this issue Apr 25, 2024 · 2 comments

Comments

@0xJoeMama
Copy link
Member

The current system in place is actually pretty shitty.
The existing code just runs through all jars and modifies the game jar.

I transformation auditing was my attempt at getting started with Felis-Project/access-widener#1. However it doesn't really help, since it requires the current project to be compiled.
In dam this could be changed so that the current project is ignored, or even we can get a dual pass system.
One pass runs dependency mod transformations and the other actually applies the current mod.

@0xJoeMama
Copy link
Member Author

New systems relating to access-widener implementations.
Auditing now happens only using the projects this project depends on. Aka, no compilation errors if everything is pulled in. The issue here is that changes to the current project cannots be reflected.

Transferring to dam, since it really is just a dam issue at this point.

@0xJoeMama 0xJoeMama transferred this issue from Felis-Project/felis May 2, 2024
@0xJoeMama
Copy link
Member Author

A dual pass system is a good idea. Basically first pass will allow for compilation of the running project and will exclude the project itself. The second pass is apply the project's transformations and include the project itself(since it is compilable thanks to step 1).

The loader and dam currently have the functionality to implement this, I just don't have the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

No branches or pull requests

1 participant