From 88854361ee0ebb0b5d3ce19809b587d716e8a10c Mon Sep 17 00:00:00 2001 From: Rowan Manning <138944+rowanmanning@users.noreply.github.com> Date: Fri, 12 Jan 2024 16:33:14 +0000 Subject: [PATCH] Replace console.error with Reliability Kit logger --- src/checks/json.check.js | 8 ++++++-- src/checks/responseCompare.check.js | 8 ++++++-- src/checks/string.check.js | 8 ++++++-- 3 files changed, 18 insertions(+), 6 deletions(-) diff --git a/src/checks/json.check.js b/src/checks/json.check.js index 1fa5078..f69f64d 100644 --- a/src/checks/json.check.js +++ b/src/checks/json.check.js @@ -3,6 +3,7 @@ const status = require('./status'); const Check = require('./check'); const fetch = require('node-fetch'); const fetchres = require('fetchres'); +const logger = require('@dotcom-reliability-kit/logger'); class JsonCheck extends Check{ @@ -24,8 +25,11 @@ class JsonCheck extends Check{ let result = this.callback(json); this.status = result ? status.PASSED : status.FAILED; - } catch(err) { - console.error('Failed to get JSON', err); + } catch(error) { + logger.error({ + event: 'JSON_CHECK_ERROR', + message: `Failed to fetch JSON from ${this.url}` + }, error); this.status = status.FAILED; } } diff --git a/src/checks/responseCompare.check.js b/src/checks/responseCompare.check.js index 7820521..e717fb8 100644 --- a/src/checks/responseCompare.check.js +++ b/src/checks/responseCompare.check.js @@ -2,6 +2,7 @@ const status = require('./status'); const Check = require('./check'); const fetch = require('node-fetch'); +const logger = require('@dotcom-reliability-kit/logger'); function allEqual(responses){ for(let i = 1, l = responses.length; i < l; i++){ @@ -49,8 +50,11 @@ class ResponseCompareCheck extends Check { if(this.comparison === ResponseCompareCheck.comparisons.EQUAL){ this.status = allEqual(responses) ? status.PASSED : status.FAILED; } - } catch(err) { - console.error('Response was not OK', err); + } catch(error) { + logger.error({ + event: 'RESPONSE_COMPARE_CHECK_ERROR', + message: 'Response was not OK' + }, error); this.status = status.FAILED; } } diff --git a/src/checks/string.check.js b/src/checks/string.check.js index b5616b8..d5362b3 100644 --- a/src/checks/string.check.js +++ b/src/checks/string.check.js @@ -3,6 +3,7 @@ const status = require('./status'); const Check = require('./check'); const fetch = require('node-fetch'); const fetchres = require('fetchres'); +const logger = require('@dotcom-reliability-kit/logger'); class StringCheck extends Check { @@ -25,8 +26,11 @@ class StringCheck extends Check { try { const body = await fetch(this.url, this.fetchOptions).then(fetchres.text); this.status = body === this.expected ? status.PASSED : status.FAILED; - } catch(err) { - console.error('Response was not OK', err); + } catch(error) { + logger.error({ + event: 'STRING_CHECK_ERROR', + message: 'Response was not OK' + }, error); this.status = status.FAILED; } }