From a5c18e9b0790d283da7f9a63d14024117624d996 Mon Sep 17 00:00:00 2001 From: Jesus Redondo Date: Fri, 24 Jun 2022 14:34:22 +0200 Subject: [PATCH 1/3] Make message for successful Fastly key expiration check to comply with the standard --- src/checks/fastlyKeyExpiration.check.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/checks/fastlyKeyExpiration.check.js b/src/checks/fastlyKeyExpiration.check.js index cd54178..9df22fd 100644 --- a/src/checks/fastlyKeyExpiration.check.js +++ b/src/checks/fastlyKeyExpiration.check.js @@ -52,7 +52,7 @@ class FastlyKeyExpirationCheck extends Check { }, PASSED: { status: status.PASSED, - checkOutput: 'Fastly key expiration date is ok', + checkOutput: `Fastly key ${this.name} is configured correctly`, severity: this.severity } }); From 6a1ffc093419568527715bbd217b520d854aeaf2 Mon Sep 17 00:00:00 2001 From: Jesus Redondo Date: Fri, 24 Jun 2022 14:44:23 +0200 Subject: [PATCH 2/3] Add link to the Health Check standard documentation --- README.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 6082164..2e05aed 100644 --- a/README.md +++ b/README.md @@ -1,6 +1,7 @@ # n-health [![CircleCI](https://circleci.com/gh/Financial-Times/n-health.svg?style=svg)](https://circleci.com/gh/Financial-Times/n-health) -Collection of healthcheck classes to use in your nodejs application +Collection of healthcheck classes to use in your nodejs application. +To create a new health check, please follow the [current standard](https://docs.google.com/document/edit?id=1ftlkDj1SUXvKvKJGvoMoF1GnSUInCNPnNGomqTpJaFk) ## Usage From e0472512e9798cc606dad00e335353e5c58ad751 Mon Sep 17 00:00:00 2001 From: Jesus Redondo Date: Fri, 24 Jun 2022 15:00:16 +0200 Subject: [PATCH 3/3] Fix test message --- test/fastlyKeyExpiration.check.spec.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/fastlyKeyExpiration.check.spec.js b/test/fastlyKeyExpiration.check.spec.js index 59b26ff..88b3205 100644 --- a/test/fastlyKeyExpiration.check.spec.js +++ b/test/fastlyKeyExpiration.check.spec.js @@ -49,7 +49,7 @@ describe('Fastly Key Expiration Check', () => { }, PASSED: { status: status.PASSED, - checkOutput: 'Fastly key expiration date is ok', + checkOutput: `Fastly key ${defaultOptions.name} is configured correctly`, severity: 2 } };