Skip to content
This repository has been archived by the owner on Mar 22, 2024. It is now read-only.

Make static assets S3 bucket name configurable #551

Closed
i-like-robots opened this issue Feb 18, 2019 · 1 comment
Closed

Make static assets S3 bucket name configurable #551

i-like-robots opened this issue Feb 18, 2019 · 1 comment

Comments

@i-like-robots
Copy link
Contributor

Currently the deploy-hashed-assets task will send files from the configured local directory (./public/ by default) to a folder named hashed-assets/app-name (app-name being inferred from the application's pkg.name).

https://github.com/Financial-Times/n-heroku-tools/blob/master/tasks/deploy-hashed-assets.js#L66

With the Core UI project we intend to deploy all hashed assets to a shared folder. This is because we will be splitting our JS bundle into more granular parts with the intention that this will increase cache-ability, reduce the amount we bust the cache, and enable greater reuse of assets between our user facing applications.

@i-like-robots
Copy link
Contributor Author

Fixed by #556 and #560

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant