Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove time-based upgrade #787

Closed
4 tasks done
dudong2 opened this issue Nov 8, 2022 · 1 comment · Fixed by #889
Closed
4 tasks done

remove time-based upgrade #787

dudong2 opened this issue Nov 8, 2022 · 1 comment · Fixed by #889
Assignees
@dudong2
Labels
A: bug Something isn't working

Comments

@dudong2
Copy link
Contributor

dudong2 commented Nov 8, 2022

Summary

When a time based upgrade was performed in cosmos-sdk, there was a case where the node could not consensus normally.
Cosmos-sdk merged pr aboue removing time based upgrade.
We need to reflect this.

ref: cosmos/cosmos-sdk#8849

Problem Definition

Proposal

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@dudong2 dudong2 added the A: bug Something isn't working label Nov 8, 2022
@dudong2 dudong2 self-assigned this Nov 8, 2022
@zemyblue
Copy link
Member

zemyblue commented Feb 9, 2023 •
edited
Loading

Cosmos-sdk seems to have the same issue.
So I think it's better to propose about removing time-based upgrade proto in cosmos-sdk, and if the proposal is approved and merged, then apply it. How about this, @dudong2 ?

@dudong2 dudong2 mentioned this issue Feb 9, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dudong2 dudong2

Labels
A: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: remove time-based upgrade dudong2/lbm-sdk
2 participants
@zemyblue @dudong2