Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimisers not work for real number #790

Closed
del2z opened this issue Jun 10, 2019 · 2 comments
Closed

Optimisers not work for real number #790

del2z opened this issue Jun 10, 2019 · 2 comments

Comments

@del2z
Copy link

del2z commented Jun 10, 2019

I reviewed the implementations of optimisers, most of them use @. to update the internal states. It seems that these optimisers (Momentum, Nesterov, RMSProp etc) do not work with TrackedReal object. I wonder if this is done intentionally in order to force people using array-like parameters instead of real number.

@MikeInnes
Copy link
Member

The optimisers are just heavily designed for Tracker-style usage (where we have mutable reference types like arrays everywhere); ideally optimisers would just work with whatever you give them, including scalars. This is going to happen gradually with #637.

@del2z
Copy link
Author

del2z commented Jun 11, 2019

OK, I see.

@del2z del2z closed this as completed Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants