-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parsing GeoJSON without timestamps #249
Comments
I'd say, returning Does wanderin.gs not return any timestamp in somehow otherwise named attribute within |
Looking at the output json a little closer: {
"type": "FeatureCollection",
"features": [
{
"type": "Feature",
"properties": {
"dur": 5235,
"ts": 1516068164735,
"acc": 1000,
"age": 209325249702,
"src": "w"
},
"geometry": {
"type": "Point",
"coordinates": [
]
}
}, I took a peek at the geojson rfc it doesn't look like there is any specific time stamp definition. I'll see if I can play with this locally a bit more. Seems like |
@dmitrym0 |
@Freika yes it is. |
@dmitrym0 I wonder why first example didn't have it 🤔 If we can be sure that |
Perhaps it can be a two-step process? You can get the timezone from the lat/long combination, and then apply it to the timestamp. I used that approach to geocode the EXIF files, that store the time without a timezone. I believe, it won't work only for that 1 ambiguous hour during the autumn DST change. |
Great idea, would've never occurred to me. Time handling is a challenge! |
Describe the bug
Dawarich's GeoJSON parsing expects a timestamp to be included for every feature.
Some GeoJSON exports (see wanderin.gs) do not include them.
This is a valid GeoJSON:
but Dawarich will throw an exception here because it expects timestamp to be included.
I overrode this behaviour thusly, so something is returned.
I figure this likely breaks line segment drawing because some points are out of order. Happy to work on a fix if you have thoughts on how to fix this better - if timestamps are not available.
Version
0.13.5
To Reproduce
Expected behavior
Import timestamp-less GeoJSON. For ordering we can perhaps use the ordering from the json file?
Logs
The text was updated successfully, but these errors were encountered: