From a0b1df5ca498fb56c14454c0a697b1eb2246310a Mon Sep 17 00:00:00 2001 From: Grzegorz Rozdzialik Date: Tue, 19 Sep 2023 20:03:04 +0200 Subject: [PATCH 1/2] chore(ci): stop testing on go 1.17, start testing on go stable go 1.17 (released in 2021) no longer works with the latest version of shfmt, which is used in the integration tests. This causes tests to fail [0]. Let's no longer test using this version. Aside from that, let's start testing using the `stable` version, so we automatically test using the latest stable without having to update the workflow file. [0]: https://github.com/Gelio/go-global-update/actions/runs/5913449961/job/16724266609?pr=19 --- .github/workflows/ci.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 6d8eb2e..67c100e 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -9,7 +9,7 @@ jobs: build-and-test: strategy: matrix: - go-version: ["1.17", "1.18", "1.19", "1.20"] + go-version: ["1.18", "1.19", "1.20", "1.21", "stable"] os: [ubuntu-latest, macos-latest, windows-latest] # Continue other jobs if one matrix job fails fail-fast: false @@ -25,7 +25,8 @@ jobs: # NOTE: only verify formatting on Linux and the latest go version. # It only needs to happen once, and formatting # is not consistent on Windows. - if: ${{ startsWith(matrix.os, 'ubuntu') && matrix.go-version == '1.20'}} + if: + ${{ startsWith(matrix.os, 'ubuntu') && matrix.go-version == 'stable'}} # NOTE: hacky bash `if` because gofumpt always returns 0 exit code # @see https://github.com/mvdan/gofumpt/issues/114 From 9c8628b77b0496cf8156e8c278c4f5376fd4d51b Mon Sep 17 00:00:00 2001 From: Grzegorz Rozdzialik Date: Tue, 19 Sep 2023 20:09:27 +0200 Subject: [PATCH 2/2] chore(ci): update versions of GitHub actions Use the latest stable versions for actions used in jobs. --- .github/workflows/ci.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 67c100e..dea161b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -15,8 +15,8 @@ jobs: fail-fast: false runs-on: ${{ matrix.os }} steps: - - uses: actions/checkout@v2 - - uses: actions/setup-go@v2 + - uses: actions/checkout@v4 + - uses: actions/setup-go@v4 with: go-version: ${{ matrix.go-version }} @@ -45,8 +45,8 @@ jobs: verify-table-of-contents: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 - - uses: actions/setup-node@v2 + - uses: actions/checkout@v4 + - uses: actions/setup-node@v3 with: node-version: "18" - run: npm install