Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate pylint configurations from .pylintrc to pyproject.toml #1740

Closed
seisman opened this issue Feb 11, 2022 · 0 comments · Fixed by #1755
Closed

Migrate pylint configurations from .pylintrc to pyproject.toml #1740

seisman opened this issue Feb 11, 2022 · 0 comments · Fixed by #1755
Labels
maintenance Boring but important stuff for the core devs
Milestone

Comments

@seisman
Copy link
Member

seisman commented Feb 11, 2022

Description of the desired feature

The pylint configuration file .pylintrc was added since the start of the project (#73), and was sometimes updated/refreshed to fit new pylint versions (e.g., #484).

I feel the current .pylintrc file is difficult to read and maintain, because:

  1. The file is too long (611 lines) and large (18.3 Kb)
  2. It contains too many settings and many of them are the same as pylint's default settings

pylint started to support pyproject.toml file since v2.5.0. I think we can remove the .pylintrc file and only keep the PyGMT-specific pylint settings in the pyproject.toml file. I'm not sure the number of PyGMT-specific settings but I expect the number is very small (less than 10).

Are you willing to help implement and maintain this feature? Yes, but discuss first.

@seisman seisman added the maintenance Boring but important stuff for the core devs label Feb 11, 2022
@seisman seisman added this to the 0.6.0 milestone Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant