Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link Checker Report on 2022-10-09 #2151

Closed
github-actions bot opened this issue Oct 9, 2022 · 3 comments Β· Fixed by #2158
Closed

Link Checker Report on 2022-10-09 #2151

github-actions bot opened this issue Oct 9, 2022 · 3 comments Β· Fixed by #2158
Labels
maintenance Boring but important stuff for the core devs
Milestone

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2022

Summary

Status Count
πŸ” Total 22598
βœ… Successful 5688
⏳ Timeouts 0
πŸ”€ Redirected 0
πŸ‘» Excluded 16907
❓ Unknown 0
🚫 Errors 3

Errors per input

Errors in documentation/dev/api/generated/pygmt.Figure.ternary.html

Errors in documentation/dev/_modules/pygmt/src/ternary.html

Errors in documentation/dev/gallery/symbols/bars.html

Full Github Actions output

@maxrjones
Copy link
Member

As an explanation for these failures, #1859 set the canonical url to point to the latest version. For any pages added since the last release, the link checker will fail on that url.

Options include closing these issues weekly if they only flag recently added pages or exclude links with the format https://pygmt.org/latest/* from the action.

@seisman
Copy link
Member

seisman commented Oct 12, 2022

As an explanation for these failures, #1859 set the canonical url to point to the latest version. For any pages added since the last release, the link checker will fail on that url.

Thanks for finding the cause.

closing these issues weekly if they only flag recently added pages

It sounds a bad option because these issues are annoying and we really can't remember exactly which pages are newly added.

exclude links with the format https://pygmt.org/latest/* from the action.

It should work but it makes me worry about potential side-effects.

Another solution is to have a "dynamic" htmt_baseurl based on the PyGMT version, similar to what we're doing at

pygmt/doc/conf.py

Lines 138 to 141 in 211e03f

if len(__version__.split("+")) > 1 or __version__ == "unknown":
version = "dev"
else:
version = __version__

if len(__version__.split("+")) > 1 or __version__ == "unknown":
    html_baseurl = "https://pygmt.org/dev/"
else:
    html_baseurl = "https://pygmt.org/latest/"

@seisman seisman added this to the 0.8.0 milestone Oct 12, 2022
@seisman seisman added the maintenance Boring but important stuff for the core devs label Oct 12, 2022
@maxrjones
Copy link
Member

Another solution is to have a "dynamic" htmt_baseurl based on the PyGMT version, similar to what we're doing at

pygmt/doc/conf.py

Lines 138 to 141 in 211e03f

if len(__version__.split("+")) > 1 or __version__ == "unknown":
version = "dev"
else:
version = __version__

if len(__version__.split("+")) > 1 or __version__ == "unknown":
    html_baseurl = "https://pygmt.org/dev/"
else:
    html_baseurl = "https://pygmt.org/latest/"

This seems like a good idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants