Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility screenshot is not correct #15598

Closed
2 tasks done
themanojshukla opened this issue Nov 10, 2023 · 2 comments
Closed
2 tasks done

Accessibility screenshot is not correct #15598

themanojshukla opened this issue Nov 10, 2023 · 2 comments
Assignees

Comments

@themanojshukla
Copy link

FAQ

URL

https://www.wonderschool.com/corp/

What happened?

When I go to https://www.wonderschool.com/corp/ website in google chrome, and open lightouse via developer option and select below things:

  • Mode: Snapshot
  • Device: Desktop
  • Category: Accessibility

then I click on 'Analyze Page Issue' button and I get accessibility report created. But the screenshot of the image is not having all parts of the website, eg, footer is missing, too many blank spaces are there, some middle page content also missing. However, if we look at the website between footer and header, a lot of section is there.

What did you expect?

I expect that the full page screenshot of my website should be captured, so that the highlighting rectangle should fit properly to all error nodes.

What have you tried?

In addition to chrome's dev tool lghthouse, I tried to use CLI and Node as well, versions are same as above, for CLI I also tried v11.2.0 & v11.3.0. Still the issue is same.

How were you running Lighthouse?

CLI, node, Chrome DevTools

Lighthouse Version

11.0.0

Chrome Version

118.0.5993.88

Node Version

18.18.2

OS

Ubuntu 23.04 / Kernel version:Linux 6.2.0-35-generic

Relevant log output

See the Lightouse report here 

https://googlechrome.github.io/lighthouse/viewer/?gist=cc2dfc8f3e78c8b03c4437630f2ef4b9
@adamraine
Copy link
Member

Related #14336

When Lighthouse takes the full page screenshot it expands the viewport vertically to capture as much content as possible. This is so we can visually capture elements that get called out in the report. Capturing the screenshot always happens after Lighthouse analyzes the page so the viewport change shouldn't affect your result.

We disable the viewport expansion in user flows as it can affect future flow step results. However, we don't disable for individual modes being run in DevTools.

@paulirish
Copy link
Member

The page is ~9000px tall. to get a full screenshot, lighthouse makes the viewport 9000px tall.. just like this:
image

but... the page layout doesn't look good there.. probably because this rule.. perhaps others:
image

yeah i think the way you did parallax just isnt friendly to this very-tall-viewport situation.. :/

not really a problem (we applaud no-js parallax!) .. but.. that's whats going on.

as we don't see this often we're not going to try to do some workaround to resolve it. (tbh i'm not sure we even could)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants