Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit: Attribute mainthread costs by framework #2631

Closed
evenstensberg opened this issue Jul 2, 2017 · 5 comments
Closed

Audit: Attribute mainthread costs by framework #2631

evenstensberg opened this issue Jul 2, 2017 · 5 comments

Comments

@evenstensberg
Copy link
Contributor

Don't know if this is possible, close if irrelevant or if this is implemented in some way.

Summary

I think it would be convenient to include how much of the framework code is included in the FMP or TTI. This way, authors have more of an indication of what code they need to strip in order to gain a good audit on TTI or FMP. Tools that are reliant on lighthouse could also benefit from this, as you could with, for instance webpack, make sure to split your bundles into vendor chunks. Don't really know how to approach this problem though.

https://youtu.be/aCMbSyngXB4?t=2m55s

CC-ing in @addyosmani for more thoughts.

@tdresser
Copy link

tdresser commented Jul 4, 2017

I suspect we can do something like this.

We have approximate code coverage data - we just need to take a snapshot at FMP or TTI.

@evenstensberg
Copy link
Contributor Author

I think the hard part would be to split your code from the framework associated code, as this sometimes intersects. I may be wrong though

@patrickhulce
Copy link
Collaborator

This would be great! I also fear this falls into the problem of the more sophisticated the user (bundling assets where coverage data is difficult to disentangle, etc) the less likely we'll be able to accurately report this information, which is unfortunate since I suspect they're also the most likely to take action on it.

@tdresser
Copy link

tdresser commented Jul 5, 2017

Is splitting out framework logic necessary for this?

I would have thought just indicating what code had executed at the time of FMP/TTI would be pretty useful.

@paulirish paulirish changed the title Audit for framework associated load on FMP and TTI Audit: Attribute mainthread costs by framework Oct 12, 2017
@brendankenny
Copy link
Member

let's close and defer to a few other issues like

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants