Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis, Docker, and Kokoro all use different golang versions #947

Closed
cvgw opened this issue Jan 3, 2020 · 4 comments
Closed

Travis, Docker, and Kokoro all use different golang versions #947

cvgw opened this issue Jan 3, 2020 · 4 comments
Assignees
Labels
area/internal bugs related to kaniko development workflow area/testing Issues related to testing kaniko itself kind/bug Something isn't working priority/p2 High impact feature/bug. Will get a lot of users happy

Comments

@cvgw
Copy link
Contributor

cvgw commented Jan 3, 2020

Actual behavior
Kokoro, Travis, and the Kaniko Dockerfiles all use different Golang versions

Travis is 1.13

- "1.13.3"

Dockerfile is 1.12

FROM golang:1.12

I have no idea what Kokoro is using but it's not 1.13 because testing.Init is not available and that was added in 1.13

Expected behavior
Kokoro, Travis, and the Kaniko docker files should all use the same golang version

To Reproduce
N/A

Additional Information

Triage Notes for the Maintainers

Description Yes/No
Please check if this a new feature you are proposing
Please check if the build works in docker but not in kaniko
Please check if this error is seen when you use --cache flag
Please check if your dockerfile is a multistage dockerfile
@cvgw cvgw added kind/bug Something isn't working area/testing Issues related to testing kaniko itself area/internal bugs related to kaniko development workflow labels Jan 3, 2020
@tejal29 tejal29 added this to the GA Release v1.0.0 milestone Jan 10, 2020
@tejal29
Copy link
Member

tejal29 commented Jan 10, 2020

@samos123 is working on this on this branch to move off kokoro

@tejal29 tejal29 added the priority/p2 High impact feature/bug. Will get a lot of users happy label Jan 22, 2020
@tejal29
Copy link
Member

tejal29 commented Jan 24, 2020

@samos123 is this fixed now?

@samos123
Copy link
Contributor

Yes, however I will still need to update the Dockerfile to use 1.13 as well. It's still using 1.12 in the dockerfile. Let me create a PR for that.

@samos123
Copy link
Contributor

Actually seems the Dockerfiles have already been updated to use 1.13 in master. So this can be closed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/internal bugs related to kaniko development workflow area/testing Issues related to testing kaniko itself kind/bug Something isn't working priority/p2 High impact feature/bug. Will get a lot of users happy
Projects
None yet
Development

No branches or pull requests

3 participants