Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Entities lightweight #323

Closed
GregHib opened this issue Feb 25, 2023 · 1 comment
Closed

Make Entities lightweight #323

GregHib opened this issue Feb 25, 2023 · 1 comment
Labels
data enhancement New feature or request object wontfix This will not be worked on

Comments

@GregHib
Copy link
Owner

GregHib commented Feb 25, 2023

Might be worth reconsidering:

  • How ChunkUpdate's are stored for entities
  • How owner's are handled
  • If Event's is necessary for all entities Improve event handling #324
  • Converting most entities to Record's

Floor item state, respawn handling will be harder without tracking event's
GameObjects also handling respawning and temp replacing

Main gain to be made is faster map loading when GameObject's don't take as long to create. (750ms -> 150ms with cache)

@GregHib GregHib added enhancement New feature or request wontfix This will not be worked on data object labels Feb 25, 2023
@GregHib
Copy link
Owner Author

GregHib commented Jun 9, 2023

Removed Events and Size from Entity so it's now only Tile.

Objects are now lightweight #345

FloorItems wasn't possible as they require an owner, and the owner must be stored as a string as a player logging back in can end up with a different index.

@GregHib GregHib closed this as completed Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data enhancement New feature or request object wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant