Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on Windows #132

Closed
rmarquis opened this issue Apr 17, 2024 · 1 comment
Closed

Fix build on Windows #132

rmarquis opened this issue Apr 17, 2024 · 1 comment
Assignees

Comments

@rmarquis
Copy link
Contributor

Using the build frontend, we realized the build/packaging was not succeeding correctly, resulting in the dimlp and fidex libraries missing from the binary wheel.

After investigation, it seems the hatch build backend is not approriate for binaries with bindings. An alternative way is to use the scikit-build-core build backend, which is simple and works great with one caveat: it requires the WIndows binaries to be built with MSVC as MingW is not supported (which makes sense as Python windows banaried are built with msvc).

In turn, this requires the CMake files to be adjusted for MSVC. Some partial work is available in the fixbuildmsvc branch. Some minor code changes might be required too.

Alternative:

@rmarquis rmarquis self-assigned this Apr 17, 2024
@rmarquis
Copy link
Contributor Author

rmarquis commented May 7, 2024

Done in 5d14256.

@rmarquis rmarquis closed this as completed May 7, 2024
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant