Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal: remove Dispatcher from HeliosProfile #258

Closed
derammo opened this issue Jul 5, 2020 · 2 comments
Closed

internal: remove Dispatcher from HeliosProfile #258

derammo opened this issue Jul 5, 2020 · 2 comments
Assignees
@derammo
Labels
enhancement New feature or request fixed Code is complete, waiting for release internal Issue is not expected to have user-visible impact
Milestone
Release1636

Comments

@derammo
Copy link

derammo commented Jul 5, 2020

Helios is almost entirely single threaded now and we just use the application dispatcher in a few places to run things on the UI thread. The dispatcher stored throughout the hierarchy isn't used anyway and just leads to cases where it is null and results in a crash.
@derammo derammo added enhancement New feature or request internal Issue is not expected to have user-visible impact labels Jul 5, 2020
@derammo derammo added this to the LongTerm milestone Jul 5, 2020
@derammo derammo self-assigned this Jul 5, 2020
@derammo derammo modified the milestones: LongTerm, ShortTerm Aug 23, 2020
@derammo
Copy link
Author

derammo commented Aug 23, 2020

in progress

@derammo
Copy link
Author

derammo commented Aug 23, 2020

see also #252

@derammo derammo added the fixed Code is complete, waiting for release label Jul 22, 2021
@derammo derammo modified the milestones: ShortTerm, Release1636 Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@derammo derammo

Labels
enhancement New feature or request fixed Code is complete, waiting for release internal Issue is not expected to have user-visible impact
Projects
None yet
Milestone
Release1636
Development

No branches or pull requests
1 participant
@derammo