Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding interface location causing crash #409

Closed
LeIceHomme opened this issue Apr 3, 2021 · 3 comments
Closed

Adding interface location causing crash #409

LeIceHomme opened this issue Apr 3, 2021 · 3 comments
Assignees
@derammo
Labels
bug Something isn't working fixed Code is complete, waiting for release
Milestone
Release1636

Comments

@LeIceHomme
Copy link

Trying to add an interface location in the profile editor but repeatedly crashing to desktop. Getting the error shown below.

Capture
@BlueFinBima
Copy link

I presume that this is line 243 in InstallationLocations.cs, but I'm not sure why g would be an empty or single character string.

@derammo
Copy link

derammo commented Apr 7, 2021

I didn't look at it yet, but you can easily get nonsense if the registry keys from DCS installation location have crap in them or something. Since that is external data, I should have sanitized it but apparently did not.

@derammo derammo self-assigned this May 22, 2021
@derammo derammo added the bug Something isn't working label May 22, 2021
@derammo derammo added this to the Release1636 milestone Jul 22, 2021
@derammo
Copy link

derammo commented Jul 23, 2021

fixed by just filtering any bad data instead of crashing

@derammo derammo added the fixed Code is complete, waiting for release label Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@derammo derammo

Labels
bug Something isn't working fixed Code is complete, waiting for release
Projects
None yet
Milestone
Release1636
Development

No branches or pull requests
3 participants
@derammo @BlueFinBima @LeIceHomme