Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename output options #179

Open
mfoll opened this issue Jun 20, 2018 · 0 comments
Open

rename output options #179

mfoll opened this issue Jun 20, 2018 · 0 comments
Assignees
Milestone

Comments

@mfoll
Copy link
Member

mfoll commented Jun 20, 2018

Currently the --output_vcf parameter can only be the name of the file and not the full path (see https://github.com/IARCbioinfo/needlestack/blob/v1.1b/needlestack.nf#L505 and https://groups.google.com/forum/#!topic/nextflow/ctLboXGPdwI), and the path can be given using --output_folder.

The rational was that the output also includes a PDF folder. However this can be confusing as putting the path in output_vcf is tempting. I propose to change the behaviour as follow:

--output_vcf: is the path to the output vcf (e.g. my_vcf.vcf or /path/to/my_vcf.vf or ../my_vcf.vcf)
--output_pdf: is optional and is the folder where to store the PDF folder (e.g. . or /path/to/outfolder). If absent, we put it in the same folder as the --output_vcf folder (to be extracted from the it).
--output_folder no longer exists.

Any objection or better idea?

@mfoll mfoll added this to the v1.1 milestone Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants