Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is Video capturing possible? #1

Open
iamabhiee opened this issue Feb 27, 2015 · 4 comments
Open

Is Video capturing possible? #1

iamabhiee opened this issue Feb 27, 2015 · 4 comments

Comments

@iamabhiee
Copy link

Very good library, Is it possible to integrate video capturing?

@lauraskelton
Copy link
Contributor

I don't have plans to add video capture anytime soon, but it could be a cool addition down the road!

@GabrielCartier
Copy link

We actually used the FastttCamera library in a project and added the video capturing capability. It actually does not require that much work.

The main problems are that we need to access private methods/attributes. In our case, we simply put the code inside the main class and used it with it. We wanted to make it available through FastttCamera but I wanted to check with @lauraskelton first to see how exactly she wanted this implemented.

I'll wait for her to see how we could do that and I'll be happy to provide the video capturing through a PR.

@lauraskelton
Copy link
Contributor

Thanks Gabriel, that would be awesome! In general, I'd love it if video capture in FastttCamera could be configurable similarly to how photo capture is, with proper orientation and the ability to crop to the viewport, and delegate methods for when videos have been captured and processed, and a class similar to FastttCapturedImage to pass around a reference to the video file path in the delegate methods.

@GabrielCartier
Copy link

So @lauraskelton, the main problem we ran into was for the session. We actually need to add audio inputs to the session so we can capture the video with sound. Since most of the properties are private, we did the implementation right in the fastttcamera class. Not sure if we'd rather make the required properties and method public (or protected). I wasn't sure if it was better to have a subclass so that people could still use only the photo camera or the subclass with the video functionalities.

You can take a look at the present implementation we have, although it will require some work for the PR (https://github.com/KhanFu/FastttCamera).

Give me your opinion on it when you'll have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants