From aa7180e9f65b9a03f19d789a14e92589553838f9 Mon Sep 17 00:00:00 2001 From: Tacho Date: Mon, 17 Sep 2018 15:01:15 +0300 Subject: [PATCH] fix(tooltip): add & remove aria attributes #1710 --- .../src/lib/directives/toggle/toggle.directive.ts | 1 + .../lib/directives/tooltip/tooltip.directive.ts | 15 +++++++++------ 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/projects/igniteui-angular/src/lib/directives/toggle/toggle.directive.ts b/projects/igniteui-angular/src/lib/directives/toggle/toggle.directive.ts index 7f919b5cc07..8fe874c728e 100644 --- a/projects/igniteui-angular/src/lib/directives/toggle/toggle.directive.ts +++ b/projects/igniteui-angular/src/lib/directives/toggle/toggle.directive.ts @@ -137,6 +137,7 @@ export class IgxToggleDirective implements IToggleView, OnInit, OnDestroy { * @hidden */ @HostBinding('class.igx-toggle--hidden') + @HostBinding('attr.aria-hidden') public get hiddenClass() { return this.collapsed; } diff --git a/projects/igniteui-angular/src/lib/directives/tooltip/tooltip.directive.ts b/projects/igniteui-angular/src/lib/directives/tooltip/tooltip.directive.ts index 5e2871cb534..29bbe14200d 100644 --- a/projects/igniteui-angular/src/lib/directives/tooltip/tooltip.directive.ts +++ b/projects/igniteui-angular/src/lib/directives/tooltip/tooltip.directive.ts @@ -284,13 +284,16 @@ export class IgxTooltipDirective extends IgxToggleDirective { @Input() public labelId = `${this.id}-label`; - @HostBinding('attr.aria-labelledby') - @Input('aria-labelledby') - public ariaLabelledBy = this.labelId; + // @HostBinding('attr.aria-live') + // public get ariaLive() { + // return !this.collapsed? 'assertive': 'off'; + // } + + @HostBinding('attr.role') + public get role() { + return 'tooltip'; + } - @HostBinding('attr.aria-label') - @Input('aria-label') - public ariaLabel: string | null = null; } @NgModule({