Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(igx-dropdown) move the density classes on the dropdown list container #12742

Closed
desig9stein opened this issue Mar 9, 2023 · 3 comments
Closed

(igx-dropdown) move the density classes on the dropdown list container #12742

desig9stein opened this issue Mar 9, 2023 · 3 comments
Assignees
@Lipata
Labels
🆕 status: new refactoring status: inactive Used to stale issues and pull requests 🧰 feature-request

Comments

@desig9stein
Copy link
Contributor

desig9stein commented Mar 9, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.

The density classes are applied to each dropdown item individually. Having the classes on the items makes it impossible to refactor the component to use the new sizing method using sizable().

This refactoring should be done once this PR is merged

Describe the solution you'd like

  1. The density classes should be moved to the igx-drop-down__list since the host is removed when the dropdown is open in the overlay
  2. the classes should look like this: igx-drop-down__list igx-drop-down__list--cosy igx-drop-down__list--compact
@github-actions
Copy link

github-actions bot commented May 9, 2023

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label May 9, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 17, 2023
@desig9stein desig9stein reopened this May 17, 2023
@github-actions github-actions bot removed the status: inactive Used to stale issues and pull requests label May 18, 2023
@github-actions
Copy link

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label Jul 17, 2023
@radomirchev radomirchev removed the status: inactive Used to stale issues and pull requests label Jul 17, 2023
@github-actions
Copy link

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label Sep 16, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Lipata Lipata

Labels
🆕 status: new refactoring status: inactive Used to stale issues and pull requests 🧰 feature-request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Lipata @desig9stein @radomirchev