Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Cancel" button to cancel inference (generation) #138

Open
ThiloteE opened this issue Aug 9, 2024 · 1 comment
Open

Add "Cancel" button to cancel inference (generation) #138

ThiloteE opened this issue Aug 9, 2024 · 1 comment
Labels
chat-UI This issue is related to chat UI design Priority: normal Issue has normal priority UI UI related issue
Milestone

Comments

@ThiloteE
Copy link
Collaborator

ThiloteE commented Aug 9, 2024

Add cancel button in AI summary and AI chat tabs.
Only show the cancel button, while the user is waiting for a response.
image

It is disputed, if the cancel button should delete the last message upon canceling and if there should be a distinction between "normal" response and "error message" response, how and where error messages could be stored and if there should be consistency between what is shown to the user in the UI and stored chat history.

See major discussion at #118 (comment)

@ThiloteE ThiloteE added UI UI related issue chat-UI This issue is related to chat UI design Priority: normal Issue has normal priority labels Aug 9, 2024
@InAnYan
Copy link
Owner

InAnYan commented Aug 9, 2024

😢 this asynchronous programming and how to properly shutdown a thread are so hard...

Need to think, this is a good feature

@InAnYan InAnYan added this to the Week _12 milestone Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chat-UI This issue is related to chat UI design Priority: normal Issue has normal priority UI UI related issue
Projects
None yet
Development

No branches or pull requests

2 participants