Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing watchosDeviceArm64 target #1747

Closed
suau opened this issue Dec 30, 2023 · 1 comment
Closed

missing watchosDeviceArm64 target #1747

suau opened this issue Dec 30, 2023 · 1 comment
Labels
core type:feature-proposal type:improvement Improving a current feature

Comments

@suau
Copy link
Contributor

suau commented Dec 30, 2023 •
edited
Loading

Describe the bug
Since XCode14 the ARCHS_STANDARD for watchOS includes arm64. KMP already has added the target watchosDeviceArm64, but koin hasn't included it yet

To Reproduce
Steps to reproduce the behavior:

  1. Create a KMP project
  2. Add Koin
  3. Add a watchOS app to the ios app
  4. Add watchosArm64(), watchosDeviceArm64(), watchosSimulatorArm64() to the shared build.gradle.kts
  5. Build for release
  6. Release build will fail with default settings

Expected behavior
watchos should build with default settings

Koin module and version:
koin-core:3.5.3
@suau suau mentioned this issue Jan 4, 2024
Merged
@arnaudgiuliani
Copy link
Member

Thanks, let's continue with the PR 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core type:feature-proposal type:improvement Improving a current feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arnaudgiuliani @suau